[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9984: WIP: Add bookmarks runner
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-01-19 16:38:32
Message-ID: 20180119163832.1.601CF3FFC5B94FDB () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
broulik added reviewers: Plasma, VDG, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This finds bookmarks by querying the browser which is a lot less fragile than \
poking the browser's database files manually.

TEST PLAN
  F5664124: Screenshot_20180119_172839.png <https://phabricator.kde.org/F5664124>
  Results are also a lot more sensible
  
  One major disadvantage I just now realized is that when the browser isn't running \
it won't work :/  
  The DBus API was quite straight-forward to work with, perhaps "subtext" could be \
part of the struct, but then, usually you also have urls, and then you add a \
gazillion properties to the struct? I think we could have the xml and structs be \
installed by krunner somehow, so we don't end up with copies all over the place

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D9984

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/constants.js
  extension/extension.js
  extension/manifest.json
  extension/options.html
  host/CMakeLists.txt
  host/bookmarksrunnerplugin.cpp
  host/bookmarksrunnerplugin.h
  host/dbusutils_p.h
  host/main.cpp
  host/org.kde.krunner1.xml
  host/plasma-runner-bookmarks.desktop

To: broulik, #plasma, #vdg, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, VDG, davidedmundson.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel.<br />broulik requested \
review of this revision. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9984" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This \
finds bookmarks by querying the browser which is a lot less fragile than poking the \
browser&#039;s database files manually.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p><a href="https://phabricator.kde.org/F5664124" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F5664124: \
Screenshot_20180119_172839.png</a><br /> Results are also a lot more sensible</p>

<p>One major disadvantage I just now realized is that when the browser isn&#039;t \
running it won&#039;t work :/</p>

<p>The DBus API was quite straight-forward to work with, perhaps &quot;subtext&quot; \
could be part of the struct, but then, usually you also have urls, and then you add a \
gazillion properties to the struct? I think we could have the xml and structs be \
installed by krunner somehow, so we don&#039;t end up with copies all over the \
place</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma \
Browser Integration</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D9984" \
rel="noreferrer">https://phabricator.kde.org/D9984</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>extension/_locales/en/messages.json<br /> \
extension/constants.js<br /> extension/extension.js<br />
extension/manifest.json<br />
extension/options.html<br />
host/CMakeLists.txt<br />
host/bookmarksrunnerplugin.cpp<br />
host/bookmarksrunnerplugin.h<br />
host/dbusutils_p.h<br />
host/main.cpp<br />
host/org.kde.krunner1.xml<br />
host/plasma-runner-bookmarks.desktop</div></div></div><br /><div><strong>To: \
</strong>broulik, Plasma, VDG, davidedmundson<br /><strong>Cc: </strong>plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]