[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9835: Bump min cmake version to 3.0
From:       Friedrich W. H. Kossebau <noreply () phabricator ! kde ! org>
Date:       2018-01-12 6:16:36
Message-ID: 20180112061636.1.851F77400D0451FA () phabricator ! kde ! org
[Download RAW message or body]

kossebau added a subscriber: hein.
kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:99
> 
> -ecm_configure_package_config_file(LibTaskManagerConfig.cmake.in
> +configure_package_config_file(LibTaskManagerConfig.cmake.in
> "${CMAKE_CURRENT_BINARY_DIR}/LibTaskManagerConfig.cmake"

@hein BTW, that LibTaskManagerConfig.cmake misses some `find_dependency()`s \
(+`include(CMakeFindDependencyMacro)` after this patch) for all the libs in the \
public interface. Sadly cmake does not generate that itself, so one has to manually \
note them. Similar possibly for the other installed cmake config files.

Cmp. e.g.
https://phabricator.kde.org/source/plasma-framework/browse/master/KF5PlasmaConfig.cmake.in;fab4cdd95b7ceb4e608f8e4368682fe0a589ccff$17


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9835

To: kossebau, #plasma, jriddell
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">kossebau added a subscriber: hein.<br />kossebau added inline \
comments. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9835" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D9835#inline-44681" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:99</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);"><span \
class="bright">ecm_</span>configure_package_config_file(LibTaskManagerConfig.cmake.in \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">configure_package_config_file(LibTaskManagerConfig.cmake.in </div><div \
style="padding: 0 8px; margin: 0 4px; ">    \
&quot;${CMAKE_CURRENT_BINARY_DIR}/LibTaskManagerConfig.cmake&quot; </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><a \
href="https://phabricator.kde.org/p/hein/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@hein</a> BTW, that \
LibTaskManagerConfig.cmake misses some <tt style="background: #ebebeb; font-size: \
13px;">find_dependency()</tt>s (+<tt style="background: #ebebeb; font-size: \
13px;">include(CMakeFindDependencyMacro)</tt> after this patch) for all the libs in \
the public interface.<br /> Sadly cmake does not generate that itself, so one has to \
manually note them.<br /> Similar possibly for the other installed cmake config \
files.</p>

<p style="padding: 0; margin: 8px;">Cmp. e.g.<br />
<a href="https://phabricator.kde.org/source/plasma-framework/browse/master/KF5PlasmaConfig.cmake.in;fab4cdd95b7ceb4e608f8e4368682fe0a589ccff$17" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://phabricator.kde.org/source/plasma-framework/browse/master/KF5 \
PlasmaConfig.cmake.in;fab4cdd95b7ceb4e608f8e4368682fe0a589ccff$17</a></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9835" \
rel="noreferrer">https://phabricator.kde.org/D9835</a></div></div><br \
/><div><strong>To: </strong>kossebau, Plasma, jriddell<br /><strong>Cc: \
</strong>hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]