[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9835: Bump min cmake version to 3.0
From:       Friedrich W. H. Kossebau <noreply () phabricator ! kde ! org>
Date:       2018-01-12 6:09:14
Message-ID: 20180112060914.1.2648AF6544ABCFAF () phabricator ! kde ! org
[Download RAW message or body]

kossebau added a comment.


  Similar fixes could be done to the other Plasma repos. Would care myself for \
kdeplasma-addons, as I have a build setup for that as well, so can test.

INLINE COMMENTS

> CMakeLists.txt:12
> find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets Quick \
>                 QuickWidgets Concurrent Test Script Network)
> -find_package(ECM 1.8.0 REQUIRED NO_MODULE)
> +find_package(ECM ${KF5_MIN_VERSION} REQUIRED NO_MODULE)
> set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR})

Ops, that slipped in. But might make sense to do as separate commit as well, given \
ECM is now even officially part of KF5.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9835

To: kossebau, #plasma, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9835" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Similar fixes could be done to the other \
Plasma repos. Would care myself for kdeplasma-addons, as I have a build setup for \
that as well, so can test.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9835#inline-44679" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:12</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
">find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets Quick \
QuickWidgets Concurrent Test Script Network) </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);">find_package(ECM <span \
class="bright">1.8.0</span> REQUIRED NO_MODULE) </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">find_package(ECM <span \
class="bright">${KF5_MIN_VERSION}</span> REQUIRED NO_MODULE) </div><div \
style="padding: 0 8px; margin: 0 4px; ">set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} \
${ECM_KDE_MODULE_DIR}) </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ops, \
that slipped in. But might make sense to do as separate commit as well, given ECM is \
now even officially part of KF5.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9835" \
rel="noreferrer">https://phabricator.kde.org/D9835</a></div></div><br \
/><div><strong>To: </strong>kossebau, Plasma, jriddell<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]