[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9072: make ksshaskpass work with git-lfs
From:       Fabian Vogt <noreply () phabricator ! kde ! org>
Date:       2018-01-11 11:02:07
Message-ID: 20180111110207.1.11C3560BA14E5357 () phabricator ! kde ! org
[Download RAW message or body]

fvogt added a comment.


  Looks good to me, but I wonder whether
  
  > KWallet writes an error to stderr when a 0-winId is given to openWallet() which \
is received by git-lfs and aborts the operation.  
  should be fixed more in a more general way as well.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9072

To: mkoller, cfeck, jriddell, whiting
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">fvogt added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9072" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Looks good to me, but I wonder \
whether</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>KWallet writes an error to stderr when a 0-winId is given to \
openWallet() which is received by git-lfs and aborts the operation.</p></blockquote>

<p>should be fixed more in a more general way as well.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R105 KDE SSH Password \
Dialog</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9072" \
rel="noreferrer">https://phabricator.kde.org/D9072</a></div></div><br \
/><div><strong>To: </strong>mkoller, cfeck, jriddell, whiting<br /><strong>Cc: \
</strong>fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]