[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D7246: Tooltips
From: Christoph Feck <noreply () phabricator ! kde ! org>
Date: 2018-01-10 21:41:25
Message-ID: 20180110214125.1.0CA4FF5F129778CC () phabricator ! kde ! org
[Download RAW message or body]
cfeck added inline comments.
INLINE COMMENTS
> decoration.h:179
> void requestShowWindowMenu();
> + void requestShowToolTip(QString text);
> + void requestHideToolTip();
const QString &text
> decorationbutton.cpp:292
> +{
> +
> + switch (type) {
empty line
> decorationbutton_p.h:69
>
> + QString typeToString( DecorationButtonType type );
> +
Does kwin use this "spaces inside parentheses" style?
> decoratedclientprivate.h:79
>
> + virtual void requestShowToolTip(QString &text) = 0;
> + virtual void requestHideToolTip() = 0;
const QString &
REVISION DETAIL
https://phabricator.kde.org/D7246
To: McPain, #breeze, #plasma, graesslin
Cc: cfeck, davidedmundson, jriddell, ngraham, broulik, plasma-devel, #breeze, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart
[Attachment #3 (unknown)]
<table><tr><td style="">cfeck added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7246" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7246#inline-44509" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">decoration.h:179</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> \
<span style="color: #aa4000">void</span> <span style="color: \
#004012">requestShowWindowMenu</span><span class="p">();</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">void</span> <span style="color: \
#004012">requestShowToolTip</span><span class="p">(</span><span \
class="n">QString</span> <span class="n">text</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">void</span> <span style="color: \
#004012">requestHideToolTip</span><span class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">const QString &text</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7246#inline-44507" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">decorationbutton.cpp:292</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span style="color: #aa4000">switch</span> <span \
class="p">(</span><span class="n">type</span><span class="p">)</span> <span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">empty line</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D7246#inline-44506" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">decorationbutton_p.h:69</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">QString</span> <span style="color: #004012">typeToString</span><span \
class="p">(</span> <span class="n">DecorationButtonType</span> <span \
class="n">type</span> <span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Does \
kwin use this "spaces inside parentheses" style?</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7246#inline-44505" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">decoratedclientprivate.h:79</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">virtual</span> <span style="color: #aa4000">void</span> <span style="color: \
#004012">requestShowToolTip</span><span class="p">(</span><span \
class="n">QString</span> <span style="color: #aa2211">&</span><span \
class="n">text</span><span class="p">)</span> <span style="color: #aa2211">=</span> \
<span style="color: #601200">0</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">virtual</span> <span style="color: #aa4000">void</span> <span style="color: \
#004012">requestHideToolTip</span><span class="p">()</span> <span style="color: \
#aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">const QString &</p></div></div></div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7246" \
rel="noreferrer">https://phabricator.kde.org/D7246</a></div></div><br \
/><div><strong>To: </strong>McPain, Breeze, Plasma, graesslin<br /><strong>Cc: \
</strong>cfeck, davidedmundson, jriddell, ngraham, broulik, plasma-devel, Breeze, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic