[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9773: Use 1px padding on titlebuttons
From:       Tom Anderson <noreply () phabricator ! kde ! org>
Date:       2018-01-09 20:07:04
Message-ID: 20180109200704.1.28E819AE076C8FB0 () phabricator ! kde ! org
[Download RAW message or body]

tomanderson created this revision.
tomanderson added a reviewer: Breeze.
tomanderson added a project: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
tomanderson requested review of this revision.

REVISION SUMMARY
  This patch fixes titlebutton rendering in Chromium. The headerbar used by Breeze is \
the same size when a window is maximized, but Chromium uses a smaller headerbar for \
its tabstrip background when the browser is maximized. When buttons won't fit, \
Chromium downsizes buttons. This was happening with Breeze titlebuttons since it used \
6px of padding on the top and bottom of the buttons, so the buttons appeared taller \
than they actually were. This patch changes the top and bottom padding to 1px. In \
native GTK apps, there's no change in appearance.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D9773

AFFECTED FILES
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/gtk-3.18/gtk.css
  Breeze-gtk/gtk-3.20/gtk.css

To: tomanderson, #breeze
Cc: plasma-devel, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">tomanderson created this revision.<br />tomanderson added a \
reviewer: Breeze.<br />tomanderson added a project: Breeze.<br />Restricted \
Application added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel.<br />tomanderson requested review of this revision. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9773" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>This patch fixes titlebutton rendering in Chromium. The \
headerbar used by Breeze is the same size when a window is maximized, but Chromium \
uses a smaller headerbar for its tabstrip background when the browser is maximized. \
When buttons won&#039;t fit, Chromium downsizes buttons. This was happening with \
Breeze titlebuttons since it used 6px of padding on the top and bottom of the \
buttons, so the buttons appeared taller than they actually were. This patch changes \
the top and bottom padding to 1px. In native GTK apps, there&#039;s no change in \
appearance.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R98 Breeze \
for Gtk</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9773" \
rel="noreferrer">https://phabricator.kde.org/D9773</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>Breeze-dark-gtk/gtk-3.18/gtk.css<br \
/> Breeze-dark-gtk/gtk-3.20/gtk.css<br />
Breeze-gtk/gtk-3.18/gtk.css<br />
Breeze-gtk/gtk-3.20/gtk.css</div></div></div><br /><div><strong>To: \
</strong>tomanderson, Breeze<br /><strong>Cc: </strong>plasma-devel, ZrenBot, \
ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]