[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness
From: Chris Holland <noreply () phabricator ! kde ! org>
Date: 2018-01-06 5:03:56
Message-ID: 20180106050356.1.4FCDFDA3CFD74894 () phabricator ! kde ! org
[Download RAW message or body]
Zren updated this revision to Diff 24808.
Zren retitled this revision from "[Panel Config] Scrolling over size button \
increments size by 1 and shows current thickness" to "[Panel Config] Scrolling over \
size button increments size by 2 and shows current thickness". Zren edited the \
summary of this revision. Zren added a comment.
Support touchpad "mousewheel" which is pixel perfect based off plasma-pa's code.
Now that I'm submitting this... I could probably also use this instead of the while \
loops...
var deltaThickness = wheelDelta / 120
deltaThickness = deltaThickness < 0 ? Math.ceil(deltaThickness) : \
Math.floor(deltaThickness) wheelDelta -= deltaThickness * 120
Meh. The loop pattern is tested an works (in plasma-pa too).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6392?vs=15888&id=24808
REVISION DETAIL
https://phabricator.kde.org/D6392
AFFECTED FILES
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml
To: Zren, #plasma
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">Zren updated this revision to Diff 24808.<br />Zren retitled \
this revision from "[Panel Config] Scrolling over size button increments size by \
1 and shows current thickness" to "[Panel Config] Scrolling over size \
button increments size by 2 and shows current thickness".<br />Zren edited the \
summary of this revision. <a \
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-2sr3cns7w46z3bs/" \
rel="noreferrer">(Show Details)</a><br />Zren added a comment. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6392" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Support touchpad \
"mousewheel" which is pixel perfect based off plasma-pa's code.</p>
<p>Now that I'm submitting this... I could probably also use this instead of the \
while loops...</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">var deltaThickness = \
wheelDelta / 120 deltaThickness = deltaThickness < 0 ? Math.ceil(deltaThickness) : \
Math.floor(deltaThickness) wheelDelta -= deltaThickness * 120</pre></div>
<p>Meh. The loop pattern is tested an works (in plasma-pa too).</p></div></div><br \
/><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: \
pre-wrap; color: #74777D;">The current thickness is also shown when dragging as \
well.<br /> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, \
175, .7);">Closing the ruler thing and reopening will recreate the component, so the \
Width/Height text will reset.<br /> <br />
I could use `Qt.binding(funtion(){ return panel.thickness })` but I don't think \
the panel will procedurally change with the panel's config open</span><span \
style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">The \
number disappears and is replaced with the original text after 1 second.<br /> Tested \
and works with a touchpad "mousewheel"</span>.<br /> <br />
Bug<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, \
.7);"> 372364: https://bugs.kde.org/show_bug.cgi?id=372364<br />
Reddit: https://www.reddit.com/r/kde/comments/65wdow/can_we_get_some_support_for_pixel_perfect_panel/</span><span \
style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">: \
372364</span><br /> <br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, \
.7);">Here's a demo: https://streamable.com/m2o7c</span><span style="padding: 0 \
2px; color: #333333; background: rgba(151, 234, 151, .6);">-----</span><br /> <br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, \
.7);">Not intended:</span><span style="padding: 0 2px; color: #333333; background: \
rgba(151, 234, 151, .6);">Bug Link: \
https://bugs.kde.org/show_bug.cgi?id=372364</span><br /> <span style="padding: 0 2px; \
color: #333333; background: rgba(251, 175, 175, .7);">Moving the panel's screen \
edge triggered the `panel.onThicknessChanged`<br />
Demo: https://streamable.com/8jof7</span><span style="padding: 0 2px; color: #333333; \
background: rgba(151, 234, 151, .6);">Reddit: \
https://www.reddit.com/r/kde/comments/65wdow/can_we_get_some_support_for_pixel_perfect_panel/</span><br \
/> <br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, \
.7);">The best way to fix that is probably setting `button.text = panel.thickness` in \
the mousewheel event and in every case in the "drag" onPositionChanged \
event. Unless someone else can think of something better.</span><span style="padding: \
0 2px; color: #333333; background: rgba(151, 234, 151, .6);">New Video: \
https://streamable.com/6w9ry<br /> </span></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D6392?vs=15888&id=24808" \
rel="noreferrer">https://phabricator.kde.org/D6392?vs=15888&id=24808</a></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6392" \
rel="noreferrer">https://phabricator.kde.org/D6392</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml</div></div></div><br \
/><div><strong>To: </strong>Zren, Plasma<br /><strong>Cc: </strong>davidedmundson, \
broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic