[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9549: Horizontally center shadows and make them bigger
From:       Hugo Pereira Da Costa <noreply () phabricator ! kde ! org>
Date:       2018-01-02 17:18:08
Message-ID: 20180102171806.1.11CFE50DD32BE36A () phabricator ! kde ! org
[Download RAW message or body]

hpereiradacosta added a comment.


  >> Right, that's exactly it. The old menu shadows were just hardcoded to use a \
smaller version of the old default size, and it didn't consult the default at all \
until you changed it, at which point it becomes as big as the menu shadows.  > 
  > Don't think so. The same "default" shadow size is used for the window decoration \
and for the window style. Now of course, once the style has been recompiled you need \
to restart the applications to have the new default value properly accounted for. No \
bug. Just a momentary glitch due to recompilation I think.  
  Well, I take it back. There is a bug, and it is (more or less) introduced by your \
code.  The window shadow option range and default is defined at two places (due to \
issues with kconfig generation code), and these two must be kept in sync:  \
kdecoration/breezesettingsdata.kcfg, which you changed  
  and
  kstyle/breeze.kcfg which was not updated.
  
  I just pushed the necessary modification to the second file.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9549

To: ngraham, abetts, hpereiradacosta, #vdg, #breeze, alake
Cc: rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, plasma-devel, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart


[Attachment #3 (unknown)]

<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9549" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: \
#464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>Right, that&#039;s exactly it. The old menu shadows \
were just hardcoded to use a smaller version of the old default size, and it \
didn&#039;t consult the default at all until you changed it, at which point it \
becomes as big as the menu shadows.</p></blockquote>

<p>Don&#039;t think so. The same &quot;default&quot; shadow size is used for the \
window decoration and for the window style. Now of course, once the style has been \
recompiled you need to restart the applications to have the new default value \
properly accounted for. No bug. Just a momentary glitch due to recompilation I \
think.</p></blockquote>

<p>Well, I take it back. There is a bug, and it is (more or less) introduced by your \
code.<br /> The window shadow option range and default is defined at two places (due \
to issues with kconfig generation code), and these two must be kept in sync:<br /> \
kdecoration/breezesettingsdata.kcfg, which you changed</p>

<p>and<br />
kstyle/breeze.kcfg which was not updated.</p>

<p>I just pushed the necessary modification to the second file.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9549" \
rel="noreferrer">https://phabricator.kde.org/D9549</a></div></div><br \
/><div><strong>To: </strong>ngraham, abetts, hpereiradacosta, VDG, Breeze, alake<br \
/><strong>Cc: </strong>rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]