[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9549: Horizontally center shadows and make them bigger
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-01-02 17:04:40
Message-ID: 20180102170439.1.9BC257642C042092 () phabricator ! kde ! org
[Download RAW message or body]

ngraham added a comment.


  In https://phabricator.kde.org/D9549#185034, @rkflx wrote:
  
  > I did not look at the complete code, but at least your patch does not contain \
anything which changes this coupling. I suspect to achieve the situation in the \
screenshots your patch relies on the fact that the menu shadows just use the old \
default size (which was based on the old window default size). Now as soon as you \
introduce a new default size (but only for windows), things break.  
  
  Right, that's exactly it. The old menu shadows were just hardcoded to use a smaller \
version of the old default size, and it didn't consult the default at all until you \
changed it, at which point it becomes as big as the menu shadows. This is the \
pre-existing bug in the code. With my change, it become more noticeable because now \
the default window shadow is much bigger, but it's not a new issue I've introduced. \
Before changing anything else, let's get some consensus on how we want to proceed:  
  1. Menu shadows are always small
  2. Menu shadows are always follow window shadow size
  3. Menu shadows are always follow window shadow size, with some adjustment (50% as \
big? 75% as big? 25% as big? Something else).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9549

To: ngraham, abetts, hpereiradacosta, #vdg, #breeze, alake
Cc: rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, plasma-devel, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart


[Attachment #3 (unknown)]

<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9549" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9549#185034" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" \
rel="noreferrer">D9549#185034</a>, <a href="https://phabricator.kde.org/p/rkflx/" \
style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@rkflx</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I did not look at the complete code, but at \
least your patch does not contain anything which changes this coupling. I suspect to \
achieve the situation in the screenshots your patch relies on the fact that the menu \
shadows just use the old default size (which was based on the old window default \
size). Now as soon as you introduce a new default size (but only for windows), things \
break.</p></div> </blockquote>

<p>Right, that&#039;s exactly it. The old menu shadows were just hardcoded to use a \
smaller version of the old default size, and it didn&#039;t consult the default at \
all until you changed it, at which point it becomes as big as the menu shadows. This \
is the pre-existing bug in the code. With my change, it become more noticeable \
because now the default window shadow is much bigger, but it&#039;s not a new issue \
I&#039;ve introduced. Before changing anything else, let&#039;s get some consensus on \
how we want to proceed:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">Menu shadows are always small</li>
<li class="remarkup-list-item">Menu shadows are always follow window shadow size</li>
<li class="remarkup-list-item">Menu shadows are always follow window shadow size, \
with some adjustment (50% as big? 75% as big? 25% as big? Something else).</li> \
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 \
Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9549" \
rel="noreferrer">https://phabricator.kde.org/D9549</a></div></div><br \
/><div><strong>To: </strong>ngraham, abetts, hpereiradacosta, VDG, Breeze, alake<br \
/><strong>Cc: </strong>rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]