[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9608: [KScreen Effect] Fade opacity only for transparent windows
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2018-01-02 16:41:52
Message-ID: 20180102164139.1.EDFAADBB93A164C7 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9608#184901, @broulik wrote:
  
  > > As of the effect, maybe this should rather fade in a black layer than fade out \
everything else?  >
  > I suppose. Do you have a pointer to anywhere in KWin where I could look how \
that's done? (That'll also probably mean it won't make it to 5.12 LTS :/)  
  
  There's the paintBackground functionality in Scene. It's responsible for rendering \
the lowest layer. Maybe it would be possible to expose this from the effects to call \
it at random places. Otherwise we have layer rendering in the showPaint effect. The \
disadvantage there is that you need to write drawing code for each Scene. AFAIK we \
don't have a generic "render color" feature.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9608

To: broulik, #plasma, graesslin
Cc: luebking, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added a comment.<br />Restricted Application edited \
projects, added Plasma; removed KWin. </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9608" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9608#184901" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D9608#184901</a>, <a \
href="https://phabricator.kde.org/p/broulik/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@broulik</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>As of the effect, maybe this should rather fade in a \
black layer than fade out everything else?</p></blockquote>

<p>I suppose. Do you have a pointer to anywhere in KWin where I could look how \
that&#039;s done? (That&#039;ll also probably mean it won&#039;t make it to 5.12 LTS \
:/)</p></div> </blockquote>

<p>There&#039;s the paintBackground functionality in Scene. It&#039;s responsible for \
rendering the lowest layer. Maybe it would be possible to expose this from the \
effects to call it at random places. Otherwise we have layer rendering in the \
showPaint effect. The disadvantage there is that you need to write drawing code for \
each Scene. AFAIK we don&#039;t have a generic &quot;render color&quot; \
feature.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 \
KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9608" \
rel="noreferrer">https://phabricator.kde.org/D9608</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, graesslin<br /><strong>Cc: \
</strong>luebking, plasma-devel, kwin, KWin, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]