[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9549: Horizontally center shadows and make them bigger
From:       Hugo Pereira Da Costa <noreply () phabricator ! kde ! org>
Date:       2018-01-02 15:12:13
Message-ID: 20180102151051.1.A0BEF300CF3C1701 () phabricator ! kde ! org
[Download RAW message or body]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.


  In https://phabricator.kde.org/D9549#184905, @ngraham wrote:
  
  > @rkflx, I don't see any issues when using QT_SCALE_FACTOR to simulate HiDPI. Can \
you elaborate on how you got the issues to show up?  >
  > @hpereiradacosta, are you approving this patch as-is and then we can follow up \
with more for the remaining issues brought up above?  
  
  yes !
  Many thanks for the effort.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9549

To: ngraham, abetts, hpereiradacosta, #vdg, #breeze, alake
Cc: rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, plasma-devel, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart


[Attachment #3 (unknown)]

<table><tr><td style="">hpereiradacosta accepted this revision.<br />hpereiradacosta \
added a comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 \
8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9549" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9549#184905" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D9549#184905</a>, <a \
href="https://phabricator.kde.org/p/ngraham/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@ngraham</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p><a \
href="https://phabricator.kde.org/p/rkflx/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@rkflx</a>, I don&#039;t see any \
issues when using QT_SCALE_FACTOR to simulate HiDPI. Can you elaborate on how you got \
the issues to show up?</p>

<p><a href="https://phabricator.kde.org/p/hpereiradacosta/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@hpereiradacosta</a>, are you \
approving this patch as-is and then we can follow up with more for the remaining \
issues brought up above?</p></div> </blockquote>

<p>yes !<br />
Many thanks for the effort.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9549" \
rel="noreferrer">https://phabricator.kde.org/D9549</a></div></div><br \
/><div><strong>To: </strong>ngraham, abetts, hpereiradacosta, VDG, Breeze, alake<br \
/><strong>Cc: </strong>rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]