From kde-panel-devel  Sun Dec 31 20:14:49 2017
From: Andres Betts <noreply () phabricator ! kde ! org>
Date: Sun, 31 Dec 2017 20:14:49 +0000
To: kde-panel-devel
Subject: D9549: Horizontally center shadows and make them bigger
Message-Id: <20171231201448.1.9FDAEB52FEE7A057 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=151475129825637
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--191aa3936f34458c94114051e7e61202"

--191aa3936f34458c94114051e7e61202
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

abetts added a comment.


  In https://phabricator.kde.org/D9549#184487, @hpereiradacosta wrote:
  
  > In https://phabricator.kde.org/D9549#184007, @abetts wrote:
  >
  > > @hpereiradacosta I feel this is a good direction for the theme. I am sure we can evolve it to fit new ideas.
  >
  >
  > Regarding this (and the comment you made on the other thread), I am restating my oppinion here:
  >
  > If it is only "a good direction" then it is not enough sorry.
  >
  > I would really like to avoid too many iterations on this topic. Window decoration are very visible to users, so changing it every two releases gives a really bad impression on the quality of the code and of our design. 
  >  We should get it as right as possible before pushing to the official repo.
  >
  > Andy, if you think the shadow should be improved, please indicate how so that the patch gets fixed before it gets committed. 
  >  Devs can work with patches applied to the official code, there is no need to commit for changes to be tested.
  >
  > Hugo
  
  
  I mean to say that the shadows are improved with this patch being proposed. I would not change anything. My thought is that in future years we can revisit and think if we need to make any new changes. This is a huge visual improvement in my opinion. I think we should accept the patch.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9549

To: ngraham, abetts, hpereiradacosta, #vdg, #breeze, alake
Cc: zzag, cfeck, januz, rpelorosso, apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

--191aa3936f34458c94114051e7e61202
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">abetts added a comment.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D9549" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><div><blockquote style=3D"border-left: 3px solid #8=
C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style=3D"font-style: normal;
          padding-bottom: 4px;">In <a href=3D"https://phabricator.kde.org/D=
9549#184487" style=3D"background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel=3D"noreferrer">D9549#184=
487</a>, <a href=3D"https://phabricator.kde.org/p/hpereiradacosta/" style=
=3D"
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel=3D"noreferrer">@hpereiradacosta</a> wr=
ote:</div>
<div style=3D"margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style=3D"border-left: 3px=
 solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style=3D"font-style: normal;
          padding-bottom: 4px;">In <a href=3D"https://phabricator.kde.org/D=
9549#184007" style=3D"background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel=3D"noreferrer">D9549#184=
007</a>, <a href=3D"https://phabricator.kde.org/p/abetts/" style=3D"
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel=3D"noreferrer">@abetts</a> wrote:</div>
<div style=3D"margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p><a href=3D"https://phabricator.kde=
.org/p/hpereiradacosta/" style=3D"
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel=3D"noreferrer">@hpereiradacosta</a> I =
feel this is a good direction for the theme. I am sure we can evolve it to =
fit new ideas.</p></div>
</blockquote>

<p>Regarding this (and the comment you made on the other thread), I am rest=
ating my oppinion here:</p>

<p>If it is only &quot;a good direction&quot; then it is not enough sorry.<=
/p>

<p>I would really like to avoid too many iterations on this topic. Window d=
ecoration are very visible to users, so changing it every two releases give=
s a really bad impression on the quality of the code and of our design. <br=
 />
 We should get it as right as possible before pushing to the official repo.=
</p>

<p>Andy, if you think the shadow should be improved, please indicate how so=
 that the patch gets fixed before it gets committed. <br />
 Devs can work with patches applied to the official code, there is no need =
to commit for changes to be tested.</p>

<p>Hugo</p></div>
</blockquote>

<p>I mean to say that the shadows are improved with this patch being propos=
ed. I would not change anything. My thought is that in future years we can =
revisit and think if we need to make any new changes. This is a huge visual=
 improvement in my opinion. I think we should accept the patch.</p></div></=
div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div><=
/div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><b=
r /><div><strong>REVISION DETAIL</strong><div><a href=3D"https://phabricato=
r.kde.org/D9549" rel=3D"noreferrer">https://phabricator.kde.org/D9549</a></=
div></div><br /><div><strong>To: </strong>ngraham, abetts, hpereiradacosta,=
 VDG, Breeze, alake<br /><strong>Cc: </strong>zzag, cfeck, januz, rpeloross=
o, apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moha=
med, jensreuterberg, abetts, sebas, mart<br /></div>
--191aa3936f34458c94114051e7e61202--