[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9542: Improve display of technical app info
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2017-12-29 15:00:40
Message-ID: 20171229150039.1.414AC144B58FE009 () phabricator ! kde ! org
[Download RAW message or body]

ngraham marked 2 inline comments as done.
ngraham added inline comments.

INLINE COMMENTS

> alexeymin wrote in ApplicationPage.qml:153
> Why do you put a `Text` inside a label? Why not use `font.bold` property of Label \
> itself?

This was actually the only way I could get it to work. Doing this:

  QQC2.Label {
              Layout.fillWidth: true
              text: appInfo.application.comment
              font.bold: true
              wrapMode: Text.WordWrap
              elide: Text.ElideRight
              maximumLineCount: 1
              bottomPadding: 20
          }

...had no effect, and did not make the text bold.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9542

To: ngraham, apol, #vdg, #discover_software_store
Cc: alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">ngraham marked 2 inline comments as done.<br />ngraham added \
inline comments. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 \
8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9542" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D9542#inline-43173" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">alexeymin</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">ApplicationPage.qml:153</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Why do you put a <tt \
style="background: #ebebeb; font-size: 13px;">Text</tt> inside a label? Why not use \
<tt style="background: #ebebeb; font-size: 13px;">font.bold</tt> property of Label \
itself?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">This was actually the only way I could get it to \
work. Doing this:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QQC2.Label {  \
Layout.fillWidth: true  text: appInfo.application.comment
            font.bold: true
            wrapMode: Text.WordWrap
            elide: Text.ElideRight
            maximumLineCount: 1
            bottomPadding: 20
        }</pre></div>

<p style="padding: 0; margin: 8px;">...had no effect, and did not make the text \
bold.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R134 Discover Software \
Store</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9542" \
rel="noreferrer">https://phabricator.kde.org/D9542</a></div></div><br \
/><div><strong>To: </strong>ngraham, apol, VDG, Discover Software Store<br \
/><strong>Cc: </strong>alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]