[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9512: startplasmacompositor: If available, query org.freedesktop.locale1 for XKB defaults
From:       Fabian Vogt <noreply () phabricator ! kde ! org>
Date:       2017-12-27 14:06:35
Message-ID: 20171227140634.1.D10D9FE41D0EE0DE () phabricator ! kde ! org
[Download RAW message or body]

fvogt added a comment.


  In https://phabricator.kde.org/D9512#183199, @davidedmundson wrote:
  
  > This could also be done in kcminit phase 0, it's a bit later and can then be done \
with slightly more stuff in parallel - also it'd be C++ so you can at least send all \
4 DBus requests before blocking on the first.  >
  > As long as you update both the DBus environment and the klaunch environment, \
everything else will then inherit it.  >  (kcms/input/main.cpp has an example of \
that)  
  
  Not kwin_wayland, which is the only process the variables need to be set for.
  
  It would be possible to just ignore those environment variables completely and tell \
kwin the layout over dbus with `org.kde.Keyboard`.  However, only KWin knows that the \
user didn't specify a custom layout, so just relaying the locale1 properties to kwin \
during autostart won't work.  
  IMO this is the simplest and cleanest way to achieve this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9512

To: fvogt, #plasma, graesslin
Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">fvogt added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9512" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9512#183199" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D9512#183199</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>This could also be done in kcminit phase 0, \
it&#039;s a bit later and can then be done with slightly more stuff in parallel - \
also it&#039;d be C++ so you can at least send all 4 DBus requests before blocking on \
the first.</p>

<p>As long as you update both the DBus environment and the klaunch environment, \
everything else will then inherit it.<br />  (kcms/input/main.cpp has an example of \
that)</p></div> </blockquote>

<p>Not kwin_wayland, which is the only process the variables need to be set for.</p>

<p>It would be possible to just ignore those environment variables completely and \
tell kwin the layout over dbus with <tt style="background: #ebebeb; font-size: \
13px;">org.kde.Keyboard</tt>.<br /> However, only KWin knows that the user \
didn&#039;t specify a custom layout, so just relaying the locale1 properties to kwin \
during autostart won&#039;t work.</p>

<p>IMO this is the simplest and cleanest way to achieve this.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9512" \
rel="noreferrer">https://phabricator.kde.org/D9512</a></div></div><br \
/><div><strong>To: </strong>fvogt, Plasma, graesslin<br /><strong>Cc: \
</strong>davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]