[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9487: [effects/slide] Handle moving clients
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-12-24 9:14:43
Message-ID: 20171224091443.21840.328D12E89D7C5F2D () phabricator ! kde ! org
[Download RAW message or body]

graesslin accepted this revision.
graesslin added inline comments.
This revision is now accepted and ready to land.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> slide.cpp:295-296
> +    m_backgroundContrastForcedBefore.removeAll(w);
> +    if (w == m_movingWindow)
> +        m_movingWindow = nullptr;
> +}

coding style nitpick: please wrap in {}

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9487

To: zzag, #kwin, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin accepted this revision.<br />graesslin added inline \
comments.<br />This revision is now accepted and ready to land.<br />Restricted \
Application edited projects, added KWin; removed Plasma. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9487" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9487#inline-43040" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">slide.cpp:295-296</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span \
class="n">m_backgroundContrastForcedBefore</span><span class="p">.</span><span \
class="n">removeAll</span><span class="p">(</span><span class="n">w</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span \
class="p">(</span><span class="n">w</span> <span style="color: #aa2211">==</span> \
<span class="n">m_movingWindow</span><span class="p">)</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="n">m_movingWindow</span> <span style="color: #aa2211">=</span> <span \
style="color: #aa4000">nullptr</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">coding style nitpick: please wrap in {}</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9487" \
rel="noreferrer">https://phabricator.kde.org/D9487</a></div></div><br \
/><div><strong>To: </strong>zzag, KWin, Plasma, graesslin<br /><strong>Cc: \
</strong>graesslin, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]