[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9478: Drop use of qtpaths in startkde
From:       Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date:       2017-12-22 13:09:12
Message-ID: 20171222130912.78114.C23B7AD0FFD7BC74 () phabricator ! kde ! org
[Download RAW message or body]

apol added inline comments.

INLINE COMMENTS

> apol wrote in startkde.cmake:41
> `sysConfigDirs=${XDG_CONFIG_DIRS:-/etc/xdg}`
> 
> As we did for https://phabricator.kde.org/D9299

No, with this you get to remove the if altogether.

> startplasmacompositor.cmake:24
>  fi
> +if [ ${XDG_CONFIG_DIRS} ]; then
> +    sysConfigDirs=${XDG_CONFIG_DIRS:-/etc/xdg}

Here too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9478

To: davidedmundson, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

[Attachment #3 (unknown)]

<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9478" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D9478#inline-42948" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">apol</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">startkde.cmake:41</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; \
font-size: 13px;">sysConfigDirs=${XDG_CONFIG_DIRS:-/etc/xdg}</tt></p>

<p style="padding: 0; margin: 8px;">As we did for <a \
href="https://phabricator.kde.org/D9299" class="remarkup-link" target="_blank" \
rel="noreferrer">https://phabricator.kde.org/D9299</a></p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No, with \
this you get to remove the if altogether.</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9478#inline-42952" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">startplasmacompositor.cmake:24</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "><span class="err">fi</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="err">if</span> \
<span class="err">[</span> <span class="err">${XDG_CONFIG_DIRS}</span> <span \
class="err">];</span> <span class="err">then</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="err">sysConfigDirs=${XDG_CONFIG_DIRS:-/etc/xdg}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Here \
too.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9478" \
rel="noreferrer">https://phabricator.kde.org/D9478</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>apol, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]