[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9136: Add support for version 3 of data device manager interface
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-12-10 19:24:01
Message-ID: 20171210192400.56880.72B5F551851B6B21 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added inline comments.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

INLINE COMMENTS

> broulik wrote in datadevicemanager.h:74
> Should `Ask` perhaps become a bigger number in  case stuff gets added in the middle \
> later like `Link` or is that unlikely/incompatible?

It would be incompatible. The values are the same as the flags from the wayland \
protocol

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D9136

To: graesslin, #frameworks, #plasma, #kwin
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added inline comments.<br />Restricted Application \
edited projects, added Plasma; removed Plasma on Wayland. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9136" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9136#inline-41855" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">datadevicemanager.h:74</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">Should <tt style="background: #ebebeb; font-size: 13px;">Ask</tt> \
perhaps become a bigger number in  case stuff gets added in the middle later like <tt \
style="background: #ebebeb; font-size: 13px;">Link</tt> or is that \
unlikely/incompatible?</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">It would be incompatible. The values are \
the same as the flags from the wayland protocol</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9136" \
rel="noreferrer">https://phabricator.kde.org/D9136</a></div></div><br \
/><div><strong>To: </strong>graesslin, Frameworks, Plasma, KWin<br /><strong>Cc: \
</strong>broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]