[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8787: Fix PWD dialog
From:       Ivan Čukić <noreply () phabricator ! kde ! org>
Date:       2017-12-09 6:35:29
Message-ID: 20171209063529.40637.77999B36934EDD6B () phabricator ! kde ! org
[Download RAW message or body]

ivan added a comment.


  I've pushed this patch with a few changes (don't want to wait the last moment \
before the string freeze).  
  Changes are:
  
  - Added a dialogue icon so that it looks more like the default password widget
  - Fixed the i18n invocation - i18n("something %1").arg("else") should be \
i18n("something %1", "else") - otherwise i18n will complain that it is missing an \
                argument
  - Removed the leading space
  - Added the dialogue title "Plasma Vault" - could be something better
  - Changed the layout a bit
  
  F5536125: Screenshot_20171209_073508.png <https://phabricator.kde.org/F5536125>

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8787

To: cryptodude, #plasma, ivan
Cc: abetts, colomar, jensreuterberg, ngraham, cfeck, plasma-devel, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">ivan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8787" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I&#039;ve pushed this patch with a few \
changes (don&#039;t want to wait the last moment before the string freeze).</p>

<p>Changes are:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Added a dialogue icon so that it looks more like the \
default password widget</li> <li class="remarkup-list-item">Fixed the i18n invocation \
- i18n(&quot;something %1&quot;).arg(&quot;else&quot;) should be i18n(&quot;something \
%1&quot;, &quot;else&quot;) - otherwise i18n will complain that it is missing an \
argument</li> <li class="remarkup-list-item">Removed the leading space</li>
<li class="remarkup-list-item">Added the dialogue title &quot;Plasma Vault&quot; - \
could be something better</li> <li class="remarkup-list-item">Changed the layout a \
bit</li> </ul>

<p><a href="https://phabricator.kde.org/F5536125" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F5536125: \
Screenshot_20171209_073508.png</a></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R845 Plasma Vault</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8787" \
rel="noreferrer">https://phabricator.kde.org/D8787</a></div></div><br \
/><div><strong>To: </strong>cryptodude, Plasma, ivan<br /><strong>Cc: \
</strong>abetts, colomar, jensreuterberg, ngraham, cfeck, plasma-devel, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]