[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files
From:       Anthony Fieroni <noreply () phabricator ! kde ! org>
Date:       2017-12-07 4:46:36
Message-ID: 20171207044636.118927.110A35FB35B5AD48 () phabricator ! kde ! org
[Download RAW message or body]

anthonyfieroni added inline comments.

INLINE COMMENTS

> arichardson wrote in kdeplatformfiledialoghelper.cpp:365-370
> I don't think we can depend on that yet, can we? Also I'm not sure we really need \
> that runtime check. How likely is it that someone compiles plasma integration \
> against Qt 5.7 and runs it with 5.8? Is that even supported? Aren't we using \
> private APIs?

> How likely is it that someone compiles plasma integration against Qt 5.7 and runs \
> it with 5.8?

It's likely (hypothetical), complied with 5.8 and run it with 5.7 is unsupported.

> Is that even supported?

It's supported by Qt, by KDE pretty sure - not.
I'm not stopper of this change, Elvis should accept it.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D4193

To: arichardson, #plasma
Cc: ngraham, krzyc, anthonyfieroni, elvisangelaccio, graesslin, plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart


[Attachment #3 (unknown)]

<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4193" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4193#inline-22213" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">arichardson</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">kdeplatformfiledialoghelper.cpp:365-370</span></div> <div style="margin: 8px \
0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I don&#039;t \
think we can depend on that yet, can we? Also I&#039;m not sure we really need that \
runtime check. How likely is it that someone compiles plasma integration against Qt \
5.7 and runs it with 5.8? Is that even supported? Aren&#039;t we using private \
APIs?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><blockquote \
style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: \
4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; \
margin: 8px;">How likely is it that someone compiles plasma integration against Qt \
5.7 and runs it with 5.8?</p></blockquote>

<p style="padding: 0; margin: 8px;">It&#039;s likely (hypothetical), complied with \
5.8 and run it with 5.7 is unsupported.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p \
style="padding: 0; margin: 8px;">Is that even supported?</p></blockquote>

<p style="padding: 0; margin: 8px;">It&#039;s supported by Qt, by KDE pretty sure - \
not.<br /> I&#039;m not stopper of this change, Elvis should accept \
it.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R135 Integration for Qt applications in \
Plasma</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4193" \
rel="noreferrer">https://phabricator.kde.org/D4193</a></div></div><br \
/><div><strong>To: </strong>arichardson, Plasma<br /><strong>Cc: </strong>ngraham, \
krzyc, anthonyfieroni, elvisangelaccio, graesslin, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]