[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8444: Define default Action when we plug unknown monitor
From: Milian Wolff <noreply () phabricator ! kde ! org>
Date: 2017-12-06 12:34:11
Message-ID: 20171206123410.127485.982D3149CB8D327B () phabricator ! kde ! org
[Download RAW message or body]
mwolff added a comment.
In https://phabricator.kde.org/D8444#173635, @davidedmundson wrote:
> I left a comment a month ago. It has not been addressed.
>
> > there's one part that's going to appear very confusing.
>
>
>
> > I have my (small) laptop. Lets say I want any new (big) screen to appear on the \
left. So I save "Extend to left". > > So I'd expect to see: monitor, laptop.
>
>
>
> > What will happen, is it will extend my biggest screen to the left, leaving me \
with: > > laptop, monitor
>
>
>
> > rendering the option seemingly broken.
>
> It's artbitrary depending on what size monitor you happen to plug in.
I agree that this is broken, functionality-wise. But it was broken before too, \
right? So why was the old code looking up the biggest monitor and extending it, \
instead of using the primary one?
INLINE COMMENTS
> generator.cpp:328
>
> - Q_FOREACH(const KScreen::OutputPtr &output, connectedOutputs) {
> + for (const KScreen::OutputPtr &output : qAsConst(connectedOutputs)) {
> QSet<QSize> modeSizes;
this cleanup should happen in a separate patch
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D8444
To: mlaurent, davidedmundson
Cc: mwolff, sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">mwolff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8444" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8444#173635" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8444#173635</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I left a comment a month ago. It has not \
been addressed.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>there's one part that's going to appear very \
confusing.</p></blockquote>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I \
have my (small) laptop. Lets say I want any new (big) screen to appear on the left. \
So I save "Extend to left".<br /> So I'd expect to see: monitor, \
laptop.</p></blockquote>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>What \
will happen, is it will extend my biggest screen to the left, leaving me with:<br /> \
laptop, monitor</p></blockquote>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>rendering the option seemingly broken.</p></blockquote>
<p>It's artbitrary depending on what size monitor you happen to plug \
in.</p></div> </blockquote>
<p>I agree that this is broken, functionality-wise. But it was broken before too, \
right? So why was the old code looking up the biggest monitor and extending it, \
instead of using the primary one?</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8444#inline-41442" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">generator.cpp:328</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span \
class="n"><span class="bright">Q_FOREACH</span></span><span class="p">(</span><span \
style="color: #aa4000">const</span> <span class="n">KScreen</span><span style="color: \
#aa2211">::</span><span class="n">OutputPtr</span> <span style="color: \
#aa2211">&</span><span class="n">output<span class="bright"></span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span class="n">connectedOutputs</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span \
style="color: #aa4000"><span class="bright">for</span></span><span class="bright"> \
</span><span class="p">(</span><span style="color: #aa4000">const</span> <span \
class="n">KScreen</span><span style="color: #aa2211">::</span><span \
class="n">OutputPtr</span> <span style="color: #aa2211">&</span><span \
style="color: #a0a000">output<span class="bright"></span></span><span class="bright"> \
</span><span class="p"><span class="bright">:</span></span><span class="bright"> \
</span><span class="n"><span class="bright">qAsConst</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="n">connectedOutputs<span class="bright"></span></span><span \
class="bright"></span><span class="p"><span class="bright">)</span>)</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; "> <span \
class="n">QSet</span><span style="color: #aa2211"><</span><span \
class="n">QSize</span><span style="color: #aa2211">></span> <span \
class="n">modeSizes</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this \
cleanup should happen in a separate patch</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R104 KScreen</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8444" \
rel="noreferrer">https://phabricator.kde.org/D8444</a></div></div><br \
/><div><strong>To: </strong>mlaurent, davidedmundson<br /><strong>Cc: \
</strong>mwolff, sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart<br \
/></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic