[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9209: Don't set a window icon in Plasma::Dialog
From:       Eike Hein <noreply () phabricator ! kde ! org>
Date:       2017-12-05 17:04:18
Message-ID: differential-rev-PHID-DREV-3nkj7ulnqo3edbnj65rm-req () phabricator ! kde ! org
[Download RAW message or body]

hein created this revision.
hein added reviewers: Plasma, Frameworks, davidedmundson, graesslin.
Restricted Application added projects: Plasma, Frameworks.

REVISION SUMMARY
  Setting a window icon is costly enough to be worth avoiding when it's
  not actually needed.
  
  This is a resurrection of David's old patch:
  
  https://git.reviewboard.kde.org/r/128484/
  
  The concerns in the old discussion that led to its rejection are no
  longer valid today: In the meantime we implemented a way for apps to
  announce their .desktop file in a window hint, which KWin (and libtm)
  will fall back to to look up an icon if not set. As plasmashell does
  this, we can drop the setIcon call here and won't regress.

TEST PLAN
  The pinned systray popup dialog still gets the Plasma icon in the
  Present Windows effect.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9209

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: hein, #plasma, #frameworks, davidedmundson, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">hein created this revision.<br />hein added reviewers: \
Plasma, Frameworks, davidedmundson, graesslin.<br />Restricted Application added \
projects: Plasma, Frameworks. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9209" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Setting \
a window icon is costly enough to be worth avoiding when it&#039;s<br /> not actually \
needed.</p>

<p>This is a resurrection of David&#039;s old patch:</p>

<p><a href="https://git.reviewboard.kde.org/r/128484/" class="remarkup-link" \
target="_blank" rel="noreferrer">https://git.reviewboard.kde.org/r/128484/</a></p>

<p>The concerns in the old discussion that led to its rejection are no<br />
longer valid today: In the meantime we implemented a way for apps to<br />
announce their .desktop file in a window hint, which KWin (and libtm)<br />
will fall back to to look up an icon if not set. As plasmashell does<br />
this, we can drop the setIcon call here and won&#039;t regress.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>The pinned systray popup dialog still gets \
the Plasma icon in the<br /> Present Windows effect.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9209" \
rel="noreferrer">https://phabricator.kde.org/D9209</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/plasmaquick/dialog.cpp</div></div></div><br \
/><div><strong>To: </strong>hein, Plasma, Frameworks, davidedmundson, graesslin<br \
/><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]