[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8798: Add xf86-input-libinput support for X11 mouse backend.
From: Xuetian Weng <noreply () phabricator ! kde ! org>
Date: 2017-12-04 22:22:54
Message-ID: 20171204222254.97361.A380666A27D56633 () phabricator ! kde ! org
[Download RAW message or body]
xuetianweng added a comment.
In https://phabricator.kde.org/D8798#175698, @subdiff wrote:
> Sorry for the long delay on a review.
>
> Can you give a short overview on how the switching works between Xlib and \
libinput backend on X? So what's the runtime detection if libinput is available or \
not? Somebody above said mouse kcm is not available without libinput anymore with \
this patch. But this should not happen of course. >
> Naming the config option Pointer Acceleration is problematic, because libinput \
names another property "pointer acceleration". I think we should not change the \
name. Unneeded deviation from upstream. Maybe better add a tooltip with a description \
if people complain. >
> In the touchpad kcm the backends for libinput and xlib are in different files (in \
the same backend/x11 subfolder). Is this possible here as well?
The touchpad's libinput backend is only for wayland. And it also has some different \
code to support xf86-input-libinput under its x11 directory. As I said before they \
are different things.
We haven't get to the point to support wayland in this kcm yet.
If people has better idea about the naming we can change later.. right now, we \
seems to use pointer acceleration for "rate". The profile is more clear.
Also if you check the Mouse navigation tab there's another "acceleration profile". \
I guess that's somewhat matching in the meaning.
REPOSITORY
R119 Plasma Desktop
BRANCH
mouse
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham, #plasma, jriddell
Cc: subdiff, jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, mart
[Attachment #3 (unknown)]
<table><tr><td style="">xuetianweng added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8798" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8798#175698" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8798#175698</a>, <a \
href="https://phabricator.kde.org/p/subdiff/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@subdiff</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Sorry for the long delay on a review.</p>
<p>Can you give a short overview on how the switching works between Xlib and libinput \
backend on X? So what's the runtime detection if libinput is available or not? \
Somebody above said mouse kcm is not available without libinput anymore with this \
patch. But this should not happen of course.</p>
<p>Naming the config option Pointer Acceleration is problematic, because libinput \
names another property "pointer acceleration". I think we should not change \
the name. Unneeded deviation from upstream. Maybe better add a tooltip with a \
description if people complain.</p>
<p>In the touchpad kcm the backends for libinput and xlib are in different files (in \
the same backend/x11 subfolder). Is this possible here as well?</p></div> \
</blockquote>
<p>The touchpad's libinput backend is only for wayland. And it also has some \
different code to support xf86-input-libinput under its x11 directory. As I said \
before they are different things.</p>
<p>We haven't get to the point to support wayland in this kcm yet.</p>
<p>If people has better idea about the naming we can change later.. right now, we \
seems to use pointer acceleration for "rate". The profile is more \
clear.</p>
<p>Also if you check the Mouse navigation tab there's another "acceleration \
profile". I guess that's somewhat matching in the \
meaning.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>mouse</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8798" \
rel="noreferrer">https://phabricator.kde.org/D8798</a></div></div><br \
/><div><strong>To: </strong>xuetianweng, ngraham, Plasma, jriddell<br /><strong>Cc: \
</strong>subdiff, jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic