[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8798: Add xf86-input-libinput support for X11 mouse backend.
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2017-12-04 14:37:16
Message-ID: 20171204143716.114833.3F0EE22D0AB110DA () phabricator ! kde ! org
[Download RAW message or body]

subdiff added a comment.


  Sorry for the long delay on a review.
  
  Can you give a short overview on how the switching works between Xlib and libinput \
backend on X? So what's the runtime detection if libinput is available or not? \
Somebody above said mouse kcm is not available without libinput anymore with this \
patch. But this should not happen of course.  
  Naming the config option Pointer Acceleration is problematic, because libinput \
names another property "pointer acceleration". I think we should not change the  \
name. Unneeded deviation from upstream. Maybe better add a tooltip with a description \
if people complain.  
  In the touchpad kcm the backends for libinput and xlib are in different files (in \
the same backend/x11 subfolder). Is this possible here as well?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mouse

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: subdiff, jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, mart


[Attachment #3 (unknown)]

<table><tr><td style="">subdiff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8798" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Sorry for the long delay on a review.</p>

<p>Can you give a short overview on how the switching works between Xlib and libinput \
backend on X? So what&#039;s the runtime detection if libinput is available or not? \
Somebody above said mouse kcm is not available without libinput anymore with this \
patch. But this should not happen of course.</p>

<p>Naming the config option Pointer Acceleration is problematic, because libinput \
names another property &quot;pointer acceleration&quot;. I think we should not change \
the  name. Unneeded deviation from upstream. Maybe better add a tooltip with a \
description if people complain.</p>

<p>In the touchpad kcm the backends for libinput and xlib are in different files (in \
the same backend/x11 subfolder). Is this possible here as well?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>mouse</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8798" \
rel="noreferrer">https://phabricator.kde.org/D8798</a></div></div><br \
/><div><strong>To: </strong>xuetianweng, ngraham, Plasma, jriddell<br /><strong>Cc: \
</strong>subdiff, jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]