[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9072: make ksshaskpass work with git-lfs
From:       Martin Koller <noreply () phabricator ! kde ! org>
Date:       2017-11-30 16:58:04
Message-ID: differential-rev-PHID-DREV-d4idiga6lhtwvgrj6mb3-req () phabricator ! kde ! org
[Download RAW message or body]

mkoller created this revision.
mkoller added reviewers: kossebau, cfeck, jriddell.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  On our git-lfs setup, I could not authenticate to the server due to 2 problems with \
ksshaskpass:  
  1. the git-lfs uses yet another syntax for the prompt, which was not covered by a \
regular expression  2. KWallet writes an error to stderr when a 0-winId is given to \
openWallet() which is received by git-lfs and aborts the operation.  
  The attached patch solves both issues.
  
  1. a new regexp is added
  2. I pass the desktop winId to openWallet

TEST PLAN
  using git with lfs

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9072

AFFECTED FILES
  src/main.cpp

To: mkoller, kossebau, cfeck, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">mkoller created this revision.<br />mkoller added reviewers: \
kossebau, cfeck, jriddell.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9072" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>On our git-lfs setup, I could not authenticate to the server \
due to 2 problems with ksshaskpass:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">the git-lfs uses yet another syntax for the prompt, \
which was not covered by a regular expression</li> <li \
class="remarkup-list-item">KWallet writes an error to stderr when a 0-winId is given \
to openWallet() which is received by git-lfs and aborts the operation.</li> </ol>

<p>The attached patch solves both issues.</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">a new regexp is added</li>
<li class="remarkup-list-item">I pass the desktop winId to openWallet</li>
</ol></div></div><br /><div><strong>TEST PLAN</strong><div><p>using git with \
lfs</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R105 KDE SSH \
Password Dialog</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9072" \
rel="noreferrer">https://phabricator.kde.org/D9072</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>src/main.cpp</div></div></div><br \
/><div><strong>To: </strong>mkoller, kossebau, cfeck, jriddell<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]