[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9068: Use setSize() instead of setProperty width and height
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-11-30 13:16:36
Message-ID: 20171130131636.130169.58E137533EDBB6B9 () phabricator ! kde ! org
[Download RAW message or body]

broulik added a comment.


  > I'm sure we'd done this already...
  
  I replaced all method calls to `setWidth()` and `setHeight()` but not instances \
where we went through `setProperty`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9068

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9068" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>I&#039;m sure we&#039;d done this \
already...</p></blockquote>

<p>I replaced all method calls to <tt style="background: #ebebeb; font-size: \
13px;">setWidth()</tt> and <tt style="background: #ebebeb; font-size: \
13px;">setHeight()</tt> but not instances where we went through <tt \
style="background: #ebebeb; font-size: 13px;">setProperty</tt></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9068" \
rel="noreferrer">https://phabricator.kde.org/D9068</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]