[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8856: Add support for new IdleInhibition protocol
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-11-30 8:32:34
Message-ID: 20171130083234.82590.534F51936D647C81 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.

INLINE COMMENTS

> idle_inhibition.cpp:42
> +
> +void IdleInhibition::registerShellClient(ShellClient *client)
> +{

We could do with a line in wayland-protocol docs to say it has to be a toplevel \
surface. Right now we're making an assumption. Albeit a fairly safe one.

REPOSITORY
  R108 KWin

BRANCH
  idle-inhibit

REVISION DETAIL
  https://phabricator.kde.org/D8856

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson \
added inline comments.<br />This revision is now accepted and ready to land.<br \
/>Restricted Application edited projects, added Plasma; removed KWin. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8856" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8856#inline-39292" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">idle_inhibition.cpp:42</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: \
#aa4000">void</span> <span class="n">IdleInhibition</span><span style="color: \
#aa2211">::</span><span class="n">registerShellClient</span><span \
class="p">(</span><span class="n">ShellClient</span> <span style="color: \
#aa2211">*</span><span class="n">client</span><span class="p">)</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We \
could do with a line in wayland-protocol docs to say it has to be a toplevel \
surface.<br /> Right now we&#039;re making an assumption. Albeit a fairly safe \
one.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>idle-inhibit</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8856" \
rel="noreferrer">https://phabricator.kde.org/D8856</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]