[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9055: systemsettings enhancement when used in a kiosk environment
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-11-29 16:08:05
Message-ID: 20171129160716.90647.1B119FD3421210C8 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Latest master features the line:
  
    if (!entry->noDisplay() ) {
            //add entry
  
  which isn't in your diff, is this made against some old code?
  
  KService::noDislpay already checks     if \
(!KAuthorized::authorizeControlModule(storageId())) {  
  as well as other important things.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D9055

To: sancelot, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, sancelot, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson requested changes to this revision.<br \
/>davidedmundson added a comment.<br />This revision now requires changes to proceed. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9055" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Latest master features the line:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (!entry-&gt;noDisplay() ) { \
//add entry</pre></div>

<p>which isn&#039;t in your diff, is this made against some old code?</p>

<p>KService::noDislpay already checks     if \
(!KAuthorized::authorizeControlModule(storageId())) {</p>

<p>as well as other important things.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R124 System Settings</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9055" \
rel="noreferrer">https://phabricator.kde.org/D9055</a></div></div><br \
/><div><strong>To: </strong>sancelot, Plasma, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, sancelot, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]