[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9053: Migrate powerdevil keyboard shortcuts
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-11-29 14:20:08
Message-ID: differential-rev-PHID-DREV-mb7acu23k5ywpnxxz5uf-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Powerdevil "faked" that it's name was "kded5" presumably as a way to
  keep user's keyboard shortcuts without having to write a kconf_update
  script.
  
  It then tried setting the component name to "power management".
  This fails because immediately after it does so, kscreen (which has the component \
name kded5  because it is in kded5) automatically changes the name back to "KDE \
Daemon".  
  This means two things:
  
  - the shortcuts don't end up under their own "power management" section
  
  in system settings properly.
  
  - kglobalaccel5 on every startup thinks that the locale is changed (as
  
  a component has changed name) and does some complex heavy writing which we don't \
want.  
  This patch moves everything to their own component, and provides a
  kconf_update script to move shortcuts.

TEST PLAN
  Confirmed shortcuts moved
  Confirmed we have our own "Power Management" section in systemsettings global \
shortcuts  No more writing on starting kglobalaccel5
  
  I'd be grateful if someone else could confirm that migration works correctly. \
Migration is hard to re-test.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9053

AFFECTED FILES
  CMakeLists.txt
  daemon/actions/bundled/brightnesscontrol.cpp
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/keyboardbrightnesscontrol.cpp
  kconf_update/CMakeLists.txt
  kconf_update/powerdevil_move_shortcuts.upd

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9053" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Powerdevil &quot;faked&quot; that it&#039;s name was \
&quot;kded5&quot; presumably as a way to<br /> keep user&#039;s keyboard shortcuts \
without having to write a kconf_update<br /> script.</p>

<p>It then tried setting the component name to &quot;power management&quot;.<br />
This fails because immediately after it does so, kscreen (which has the component \
name kded5<br /> because it is in kded5) automatically changes the name back to \
&quot;KDE Daemon&quot;.</p>

<p>This means two things:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">the shortcuts don&#039;t end up under their own \
&quot;power management&quot; section</li> </ul>

<p>in system settings properly.</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">kglobalaccel5 on every startup thinks that the locale \
is changed (as</li> </ul>

<p>a component has changed name) and does some complex heavy writing which we \
don&#039;t want.</p>

<p>This patch moves everything to their own component, and provides a<br />
kconf_update script to move shortcuts.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Confirmed shortcuts moved<br /> Confirmed we have our own \
&quot;Power Management&quot; section in systemsettings global shortcuts<br /> No more \
writing on starting kglobalaccel5</p>

<p>I&#039;d be grateful if someone else could confirm that migration works correctly. \
Migration is hard to re-test.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R122 Powerdevil</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9053" \
rel="noreferrer">https://phabricator.kde.org/D9053</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br /> \
daemon/actions/bundled/brightnesscontrol.cpp<br /> \
daemon/actions/bundled/handlebuttonevents.cpp<br /> \
daemon/actions/bundled/keyboardbrightnesscontrol.cpp<br /> \
kconf_update/CMakeLists.txt<br /> \
kconf_update/powerdevil_move_shortcuts.upd</div></div></div><br /><div><strong>To: \
</strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]