From kde-panel-devel  Wed Nov 29 11:40:40 2017
From: Aleix Pol <aleixpol () kde ! org>
Date: Wed, 29 Nov 2017 11:40:40 +0000
To: kde-panel-devel
Subject: Unwritten design policy Re: D9040: Revert "[Lock Screen / Login] Add "reveal password button""
Message-Id: <CACcA1RoWJjkcfcvmb9WAnYGenrx=fnMsYMYyR=YkYH=m5skxcg () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=151195568908037
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--001a1145b66a1560e1055f1d9ce9"

--001a1145b66a1560e1055f1d9ce9
Content-Type: text/plain; charset="UTF-8"

Would it make sense to maybe write it down now?
I wasn't aware of it and it's a good rule. It would be useful both for
documentation and to get inspired when new policies are required.

Aleix

On Tue, Nov 28, 2017 at 9:49 PM, David Edmundson <
noreply@phabricator.kde.org> wrote:

> davidedmundson created this revision.
> Restricted Application added a project: Plasma.
> Restricted Application added a subscriber: plasma-devel. View Revision
> <https://phabricator.kde.org/D9040>
> *REVISION SUMMARY*
>
> Up till this commit we had an unwritten policy:
>
> If it's a shared password (wifi, printer, samba) we can reveal the password
> If it's a personal password, you cannot
>
> This commit didn't unify the workspace behaviour, but broke it from what
> we have
> elsewhere user manager and polkit.
>
> It didn't fix anything, but introduced multiple issues.
>
> BUG: 387418
> and https://bugzilla.redhat.com/show_bug.cgi?id=1487169
>
> Even if we followed a kiosk restriction, I can't use that from SDDM.
>
> This reverts commit 2f9bfbc5e153cf98c33c6eebbf2859a48493f4b9.
>
> *REPOSITORY*
> R120 Plasma Workspace
>
> *BRANCH*
> master
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D9040
>
> *AFFECTED FILES*
> lookandfeel/contents/lockscreen/MainBlock.qml
> sddm-theme/Login.qml
>
> *To: *davidedmundson
> *Cc: *plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
> jensreuterberg, abetts, sebas, apol, mart
>

--001a1145b66a1560e1055f1d9ce9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Would it make sense to maybe write it down now?<div>I wasn=
&#39;t aware of it and it&#39;s a good rule. It would be useful both for do=
cumentation and to get inspired when new policies are required.<br><div><br=
></div><div>Aleix<br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Tue, Nov 28, 2017 at 9:49 PM, David Edmundson <span dir=3D"ltr">&lt;=
<a href=3D"mailto:noreply@phabricator.kde.org" target=3D"_blank">noreply@ph=
abricator.kde.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote=
" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><=
table><tbody><tr><td>davidedmundson created this revision.<br>Restricted Ap=
plication added a project: Plasma.<br>Restricted Application added a subscr=
iber: plasma-devel.
</td><td><a style=3D"text-decoration:none;padding:4px 8px;margin:0 8px 8px;=
float:right;color:#464c5c;font-weight:bold;border-radius:3px;background-col=
or:#f7f7f9;background-image:linear-gradient(to bottom,#fff,#f1f0f1);display=
:inline-block;border:1px solid rgba(71,87,120,.2)" href=3D"https://phabrica=
tor.kde.org/D9040" rel=3D"noreferrer" target=3D"_blank">View Revision</a></=
td></tr></tbody></table><br><div><strong>REVISION SUMMARY</strong><div><p>U=
p till this commit we had an unwritten policy:</p>

<p>If it&#39;s a shared password (wifi, printer, samba) we can reveal the p=
assword<br>
If it&#39;s a personal password, you cannot</p>

<p>This commit didn&#39;t unify the workspace behaviour, but broke it from =
what we have<br>
elsewhere user manager and polkit.</p>

<p>It didn&#39;t fix anything, but introduced multiple issues.</p>

<p>BUG: 387418<br>
and <a href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D1487169" class=
=3D"m_5950769330699069375remarkup-link" rel=3D"noreferrer" target=3D"_blank=
">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=3D1487169</a></p>

<p>Even if we followed a kiosk restriction, I can&#39;t use that from SDDM.=
</p>

<p>This reverts commit 2f9bfbc5e153cf98c33c6eebbf2859<wbr>a48493f4b9.</p></=
div></div><br><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspa=
ce</div></div></div><br><div><strong>BRANCH</strong><div><div>master</div><=
/div></div><br><div><strong>REVISION DETAIL</strong><div><a href=3D"https:/=
/phabricator.kde.org/D9040" rel=3D"noreferrer" target=3D"_blank">https://ph=
abricator.kde.org/<wbr>D9040</a></div></div><br><div><strong>AFFECTED FILES=
</strong><div><div>lookandfeel/contents/<wbr>lockscreen/MainBlock.qml<br>
sddm-theme/Login.qml</div></div></div><br><div><strong>To: </strong>davided=
mundson<br><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezha=
i, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br></div></blockq=
uote></div><br></div></div></div></div>

--001a1145b66a1560e1055f1d9ce9--