[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D6764: Add font size setting to the digital clock plasmoid
From: Diego Gangl <noreply () phabricator ! kde ! org>
Date: 2017-11-29 1:04:17
Message-ID: 20171129010416.119162.3029473D07D2F76F () phabricator ! kde ! org
[Download RAW message or body]
januz added a comment.
In https://phabricator.kde.org/D6764#172831, @mmustac wrote:
> I think this describes the main problem for most users (including me) very good:
> KDE Forum: Padding in plasma panels \
<https://forum.kde.org/viewtopic.php?f=285&t=139823>
Actually I posted that on the forums before deciding to make this patch :P
In https://phabricator.kde.org/D6764#173090, @ngraham wrote:
> Exactly: people in that thread think the default size is too big. I think if we \
just make the default size smaller, the complaints will go away.
Yeah, we can do that. However IMO the tricky part isn't having a setting, it's \
making the text (and/or label heights) scale relative to the size of the panel. Label \
heights and font settings depend on each other (and the helper(s)) in different ways \
depending on the form factor. Maybe I can bring the formulas from the rewrite code to \
set a fontSize, then check to see where it breaks and clamp it (hopefully it won't \
break the rest of the layout). An alternative would be to set a fixed font size, \
like say the default desktop font size or a multiplier of it. It could still keep the \
fontSizeMode to fit and be relative-ish, the font size would go shrink until the \
minimum allowed if it didn't have enough space.
REVISION DETAIL
https://phabricator.kde.org/D6764
To: januz, #plasma, #vdg
Cc: mmustac, IlyaBizyaev, davidedmundson, ngraham, Zren, mart, plasma-devel, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Attachment #3 (unknown)]
<table><tr><td style="">januz added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6764" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6764#172831" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D6764#172831</a>, <a \
href="https://phabricator.kde.org/p/mmustac/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@mmustac</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I think this describes the main problem for \
most users (including me) very good:<br /> <a \
href="https://forum.kde.org/viewtopic.php?f=285&t=139823" class="remarkup-link" \
target="_blank" rel="noreferrer">KDE Forum: Padding in plasma panels</a></p></div> \
</blockquote>
<p>Actually I posted that on the forums before deciding to make this patch :P</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6764#173090" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D6764#173090</a>, <a \
href="https://phabricator.kde.org/p/ngraham/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Exactly: people in that thread think the \
default size is too big. I think if we just make the default size smaller, the \
complaints will go away.</p></div> </blockquote>
<p>Yeah, we can do that. However IMO the tricky part isn't having a setting, \
it's making the text (and/or label heights) scale relative to the size of the \
panel. Label heights and font settings depend on each other (and the helper(s)) in \
different ways depending on the form factor. Maybe I can bring the formulas from the \
rewrite code to set a fontSize, then check to see where it breaks and clamp it \
(hopefully it won't break the rest of the layout). <br /> An alternative would \
be to set a fixed font size, like say the default desktop font size or a multiplier \
of it. It could still keep the fontSizeMode to fit and be relative-ish, the font size \
would go shrink until the minimum allowed if it didn't have enough \
space.</p></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6764" \
rel="noreferrer">https://phabricator.kde.org/D6764</a></div></div><br \
/><div><strong>To: </strong>januz, Plasma, VDG<br /><strong>Cc: </strong>mmustac, \
IlyaBizyaev, davidedmundson, ngraham, Zren, mart, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic