[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D9040: Revert "[Lock Screen / Login] Add "reveal password button""
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2017-11-28 20:49:04
Message-ID: differential-rev-PHID-DREV-7op35izcggpei4mn7aji-req () phabricator ! kde ! org
[Download RAW message or body]
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Up till this commit we had an unwritten policy:
If it's a shared password (wifi, printer, samba) we can reveal the password
If it's a personal password, you cannot
This commit didn't unify the workspace behaviour, but broke it from what we have
elsewhere user manager and polkit.
It didn't fix anything, but introduced multiple issues.
BUG: 387418
and https://bugzilla.redhat.com/show_bug.cgi?id=1487169
Even if we followed a kiosk restriction, I can't use that from SDDM.
This reverts commit 2f9bfbc5e153cf98c33c6eebbf2859a48493f4b9.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9040
AFFECTED FILES
lookandfeel/contents/lockscreen/MainBlock.qml
sddm-theme/Login.qml
To: davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">davidedmundson created this revision.<br />Restricted \
Application added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9040" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Up till \
this commit we had an unwritten policy:</p>
<p>If it's a shared password (wifi, printer, samba) we can reveal the \
password<br /> If it's a personal password, you cannot</p>
<p>This commit didn't unify the workspace behaviour, but broke it from what we \
have<br /> elsewhere user manager and polkit.</p>
<p>It didn't fix anything, but introduced multiple issues.</p>
<p>BUG: 387418<br />
and <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1487169" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://bugzilla.redhat.com/show_bug.cgi?id=1487169</a></p>
<p>Even if we followed a kiosk restriction, I can't use that from SDDM.</p>
<p>This reverts commit 2f9bfbc5e153cf98c33c6eebbf2859a48493f4b9.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9040" \
rel="noreferrer">https://phabricator.kde.org/D9040</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>lookandfeel/contents/lockscreen/MainBlock.qml<br /> \
sddm-theme/Login.qml</div></div></div><br /><div><strong>To: \
</strong>davidedmundson<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic