[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9021: determine QQC2 version at build time
From:       Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date:       2017-11-28 17:36:05
Message-ID: 20171128173604.129316.4DF346BD4B26854E () phabricator ! kde ! org
[Download RAW message or body]

apol accepted this revision.
apol added a comment.


  Okay, maybe it's not important...

INLINE COMMENTS

> CMakeLists.txt:4
> set(KF5_VERSION "5.41.0") # handled by release scripts
> -set(KF5_DEP_VERSION "5.40.0") # handled by release scripts
> +set(KF5_DEP_VERSION "5.39.0") # handled by release scripts
> 

This is unrelated and incorrect.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  mart/autoversion

REVISION DETAIL
  https://phabricator.kde.org/D9021

To: mart, #plasma, rizzitello, davidedmundson, apol
Cc: apol, rizzitello, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, mart


[Attachment #3 (unknown)]

<table><tr><td style="">apol accepted this revision.<br />apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9021" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Okay, maybe it&#039;s not \
important...</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D9021#inline-40630" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:4</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
">set(KF5_VERSION &quot;5.41.0&quot;) # handled by release scripts </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);">set(KF5_DEP_VERSION &quot;5.<span class="bright">40</span>.0&quot;) # handled \
by release scripts </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">set(KF5_DEP_VERSION &quot;5.<span \
class="bright">39</span>.0&quot;) # handled by release scripts </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
is unrelated and incorrect.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop \
Style</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>mart/autoversion</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9021" \
rel="noreferrer">https://phabricator.kde.org/D9021</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma, rizzitello, davidedmundson, apol<br \
/><strong>Cc: </strong>apol, rizzitello, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]