[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D9037: use desktop file actions instead of global shortcuts
From: Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date: 2017-11-28 17:09:27
Message-ID: 20171128170927.12846.834141A1D25DA378 () phabricator ! kde ! org
[Download RAW message or body]
apol added a comment.
Looks cool!
INLINE COMMENTS
> main.cpp:94
> View view;
> - view.setVisible(false);
> + const QString query = parser.positionalArguments().isEmpty() ? QString() : \
> parser.positionalArguments().first(); + if (parser.isSet(clipboardOption)) {
You can do `const QString query = parser.positionalArguments().value(0);`
> main.cpp:108
> + parser.parse(arguments);
> + const QString query = parser.positionalArguments().isEmpty() ? QString() : \
> parser.positionalArguments().first(); +
^ `value(0)`.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9037
To: mart, #plasma
Cc: apol, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, mart
[Attachment #3 (unknown)]
<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9037" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Looks cool!</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9037#inline-40624" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:94</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span \
class="n">View</span> <span class="n">view</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">const</span> <span class="n">QString</span> <span \
class="n">query</span> <span style="color: #aa2211">=</span> <span \
class="n">parser</span><span class="p">.</span><span \
class="n">positionalArguments</span><span class="p">().</span><span \
class="n">isEmpty</span><span class="p">()</span> <span style="color: \
#aa2211">?</span> <span class="n">QString</span><span class="p">()</span> <span \
style="color: #aa2211">:</span> <span class="n">parser</span><span \
class="p">.</span><span class="n">positionalArguments</span><span \
class="p">().</span><span class="n">first</span><span class="p">();</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">parser</span><span class="p">.</span><span class="n">isSet</span><span \
class="p">(</span><span class="n">clipboardOption</span><span class="p">))</span> \
<span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
can do <tt style="background: #ebebeb; font-size: 13px;">const QString query = \
parser.positionalArguments().value(0);</tt></p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9037#inline-40625" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:108</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span class="n">parser</span><span class="p">.</span><span \
class="n">parse</span><span class="p">(</span><span class="n">arguments</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span \
class="n">QString</span> <span class="n">query</span> <span style="color: \
#aa2211">=</span> <span class="n">parser</span><span class="p">.</span><span \
class="n">positionalArguments</span><span class="p">().</span><span \
class="n">isEmpty</span><span class="p">()</span> <span style="color: \
#aa2211">?</span> <span class="n">QString</span><span class="p">()</span> <span \
style="color: #aa2211">:</span> <span class="n">parser</span><span \
class="p">.</span><span class="n">positionalArguments</span><span \
class="p">().</span><span class="n">first</span><span class="p">();</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">^ <tt style="background: #ebebeb; font-size: \
13px;">value(0)</tt>.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9037" \
rel="noreferrer">https://phabricator.kde.org/D9037</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>apol, \
davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic