[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8982: Qml controls for kcm creation
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-11-27 11:11:53
Message-ID: 20171127111152.41952.F85A1B081C9F48D0 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in SimpleKCM.qml:23
> > but i think the scrolling should be handed by the qml part.
> 
> Why?

3 reasons:

1. because the long term goal is to get rid of the qwidget version, so even if it's \
long down the road things should be designed according to that from now.

the design for a pure qml version would be kcms to be kirigami Pages, which get \
directly inserted in a kirigami PageRow, so they manage their own scrolling

2. also makes it easier for more complicated designs where is not the whole ui \
scrolling but there is a scrollview and a form layout in the same module, as some \
mockups have.

3. if we relied on the scrolling by the kcmshell scrollarea, the QQuickWidget height \
should resize itself based on the contents size, but the contents width should depend \
from the qquickwidget width, making it a weird hybrid between  the two ResizeMode, \
which from Plasma::Dialog know how much complicated and painful it becomes

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D8982

To: mart, #plasma, hein, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8982" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8982#inline-40418" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">SimpleKCM.qml:23</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p style="padding: 0; margin: 8px;">but i think the scrolling should be \
handed by the qml part.</p></blockquote>

<p style="padding: 0; margin: 8px;">Why?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">3 \
reasons:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">because the long term goal is to get rid of the \
qwidget version, so even if it&#039;s long down the road things should be designed \
according to that from now.</li> </ol>

<p style="padding: 0; margin: 8px;">the design for a pure qml version would be kcms \
to be kirigami Pages, which get directly inserted in a kirigami PageRow, so they \
manage their own scrolling</p>

<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">also makes it easier for more complicated designs \
where is not the whole ui scrolling but there is a scrollview and a form layout in \
the same module, as some mockups have.</li> </ol>

<ol class="remarkup-list" start="3">
<li class="remarkup-list-item">if we relied on the scrolling by the kcmshell \
scrollarea, the QQuickWidget height should resize itself based on the contents size, \
but the contents width should depend from the qquickwidget width, making it a weird \
hybrid between  the two ResizeMode, which from Plasma::Dialog know how much \
complicated and painful it becomes</li> </ol></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R296 KDeclarative</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8982" \
rel="noreferrer">https://phabricator.kde.org/D8982</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma, hein, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]