[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8917: Reduce the amount of spurious property changes on ColorScope
From: Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date: 2017-11-20 15:44:55
Message-ID: differential-rev-PHID-DREV-uij422lnhbwi2itmotut-req () phabricator ! kde ! org
[Download RAW message or body]
apol created this revision.
apol added reviewers: Plasma, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
At the moment whenever something changed we were emitting colorGroupChanged
and then every color would recompute. This would end up being emitted
over 10 times at plasma startup so far.
This patch makes sure that the property will only be emitted if the color
group actually changes.
TEST PLAN
Ran plasma, didn't notice issues.
I don't see all of the changes on the property anymore
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8917
AFFECTED FILES
src/declarativeimports/core/colorscope.cpp
src/declarativeimports/core/colorscope.h
To: apol, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">apol created this revision.<br />apol added reviewers: \
Plasma, mart.<br />Restricted Application added projects: Plasma, Frameworks.<br \
/>Restricted Application added subscribers: Frameworks, plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8917" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>At the moment whenever something changed we were emitting \
colorGroupChanged<br /> and then every color would recompute. This would end up being \
emitted<br /> over 10 times at plasma startup so far.<br />
This patch makes sure that the property will only be emitted if the color<br />
group actually changes.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Ran plasma, didn't notice issues.<br /> I don't see \
all of the changes on the property anymore</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8917" \
rel="noreferrer">https://phabricator.kde.org/D8917</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/declarativeimports/core/colorscope.cpp<br /> \
src/declarativeimports/core/colorscope.h</div></div></div><br /><div><strong>To: \
</strong>apol, Plasma, mart<br /><strong>Cc: </strong>plasma-devel, Frameworks, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic