[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8493: Make Folder View screen aware
From:       Andras Mantia <noreply () phabricator ! kde ! org>
Date:       2017-11-16 12:19:37
Message-ID: 20171116121937.34877.C3B39A5D60F181B3 () phabricator ! kde ! org
[Download RAW message or body]

amantia added inline comments.

INLINE COMMENTS

> mwolff wrote in screenmapper.cpp:85
> this should imo be a for loop to make it clear that it is iterating over all items \
> (more ideomatic). Also, couldn't you use range-based for here even?

range based loop: I need access to both key and value

> mwolff wrote in screenmapper.cpp:91
> this is actually shared with above, so that could be in a lambda

I don't see what can be extracted

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, \
                mwolff
Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (unknown)]

<table><tr><td style="">amantia added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8493" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8493#inline-39212" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mwolff</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">screenmapper.cpp:85</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">this should imo be a for loop to \
make it clear that it is iterating over all items (more ideomatic). Also, \
couldn&#039;t you use range-based for here even?</p></div></div> <div style="margin: \
8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">range based loop: I need \
access to both key and value</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8493#inline-39213" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">mwolff</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">screenmapper.cpp:91</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">this is actually shared with above, so that could be in a \
lambda</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">I don&#039;t see what can be \
extracted</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8493" \
rel="noreferrer">https://phabricator.kde.org/D8493</a></div></div><br \
/><div><strong>To: </strong>amantia, Plasma, ervin, mlaurent, dvratil, hein, aacid, \
davidedmundson, apol, mwolff<br /><strong>Cc: </strong>anthonyfieroni, ngraham, \
mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]