[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8493: Make Folder View screen aware
From: Milian Wolff <noreply () phabricator ! kde ! org>
Date: 2017-11-16 12:13:55
Message-ID: 20171116121355.7290.9A6FFD25C41AF482 () phabricator ! kde ! org
[Download RAW message or body]
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
some more nits, sorry for that ;-)
INLINE COMMENTS
> screenmapper.cpp:69
> + auto adjustFirstScreen = [this, &screenId](const QString &path) {
> + int firstScreen = m_firstScreenForPath.value(path, -1);
> + if (firstScreen == screenId) {
this could now be inlined below since it's only being used in one of the branches
> screenmapper.cpp:84
> + // needs to be updated.
> + const auto newFirstScreen = \
> std::min_element(m_availableScreens.constBegin(), m_availableScreens.constEnd()); + \
> auto it = m_firstScreenForPath.begin();
this could be moved outside the branch and reused above, once the lambda is inlined
> screenmapper.cpp:85
> + const auto newFirstScreen = \
> std::min_element(m_availableScreens.constBegin(), m_availableScreens.constEnd()); + \
> auto it = m_firstScreenForPath.begin(); + while (it != \
> m_firstScreenForPath.end()) {
this should imo be a for loop to make it clear that it is iterating over all items \
(more ideomatic). Also, couldn't you use range-based for here even?
> screenmapper.cpp:91
> + // we have now the path for the screen that was removed, so adjust \
> it + pathIt = m_screensPerPath.find(it.key());
> + if (pathIt != m_screensPerPath.end()) {
this is actually shared with above, so that could be in a lambda
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, \
mwolff
Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Attachment #3 (unknown)]
<table><tr><td style="">mwolff requested changes to this revision.<br />mwolff added \
a comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8493" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>some more nits, \
sorry for that ;-)</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8493#inline-39210" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">screenmapper.cpp:69</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">auto</span> <span class="n">adjustFirstScreen</span> <span style="color: \
#aa2211">=</span> <span class="p">[</span><span style="color: \
#aa4000">this</span><span class="p">,</span> <span style="color: \
#aa2211">&</span><span class="n">screenId</span><span class="p">](</span><span \
style="color: #aa4000">const</span> <span class="n">QString</span> <span \
style="color: #aa2211">&</span><span class="n">path</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">int</span> <span class="n">firstScreen</span> <span style="color: \
#aa2211">=</span> <span class="n">m_firstScreenForPath</span><span \
class="p">.</span><span class="n">value</span><span class="p">(</span><span \
class="n">path</span><span class="p">,</span> <span style="color: \
#aa2211">-</span><span style="color: #601200">1</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">firstScreen</span> <span style="color: #aa2211">==</span> <span \
class="n">screenId</span><span class="p">)</span> <span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">this could now be inlined below since it's only being used in one \
of the branches</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D8493#inline-39211" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">screenmapper.cpp:84</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#74777d">// needs to be updated.</span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">const</span> <span style="color: #aa4000">auto</span> <span \
class="n">newFirstScreen</span> <span style="color: #aa2211">=</span> <span \
class="n">std</span><span style="color: #aa2211">::</span><span \
class="n">min_element</span><span class="p">(</span><span \
class="n">m_availableScreens</span><span class="p">.</span><span \
class="n">constBegin</span><span class="p">(),</span> <span \
class="n">m_availableScreens</span><span class="p">.</span><span \
class="n">constEnd</span><span class="p">());</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">auto</span> <span class="n">it</span> <span style="color: #aa2211">=</span> \
<span class="n">m_firstScreenForPath</span><span class="p">.</span><span \
class="n">begin</span><span class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this \
could be moved outside the branch and reused above, once the lambda is \
inlined</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8493#inline-39212" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">screenmapper.cpp:85</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">const</span> <span style="color: #aa4000">auto</span> <span \
class="n">newFirstScreen</span> <span style="color: #aa2211">=</span> <span \
class="n">std</span><span style="color: #aa2211">::</span><span \
class="n">min_element</span><span class="p">(</span><span \
class="n">m_availableScreens</span><span class="p">.</span><span \
class="n">constBegin</span><span class="p">(),</span> <span \
class="n">m_availableScreens</span><span class="p">.</span><span \
class="n">constEnd</span><span class="p">());</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">auto</span> <span class="n">it</span> <span style="color: #aa2211">=</span> \
<span class="n">m_firstScreenForPath</span><span class="p">.</span><span \
class="n">begin</span><span class="p">();</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">while</span> <span class="p">(</span><span class="n">it</span> <span \
style="color: #aa2211">!=</span> <span class="n">m_firstScreenForPath</span><span \
class="p">.</span><span class="n">end</span><span class="p">())</span> <span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this \
should imo be a for loop to make it clear that it is iterating over all items (more \
ideomatic). Also, couldn't you use range-based for here even?</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8493#inline-39213" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">screenmapper.cpp:91</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #74777d">// we have now the path for the screen that was removed, so \
adjust it</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">pathIt</span> <span \
style="color: #aa2211">=</span> <span class="n">m_screensPerPath</span><span \
class="p">.</span><span class="n">find</span><span class="p">(</span><span \
class="n">it</span><span class="p">.</span><span class="n">key</span><span \
class="p">());</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> \
<span class="p">(</span><span class="n">pathIt</span> <span style="color: \
#aa2211">!=</span> <span class="n">m_screensPerPath</span><span \
class="p">.</span><span class="n">end</span><span class="p">())</span> <span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this \
is actually shared with above, so that could be in a \
lambda</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8493" \
rel="noreferrer">https://phabricator.kde.org/D8493</a></div></div><br \
/><div><strong>To: </strong>amantia, Plasma, ervin, mlaurent, dvratil, hein, aacid, \
davidedmundson, apol, mwolff<br /><strong>Cc: </strong>anthonyfieroni, ngraham, \
mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic