[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8493: Make Folder View screen aware
From:       Milian Wolff <noreply () phabricator ! kde ! org>
Date:       2017-11-16 10:46:10
Message-ID: 20171116104609.29859.4A163B78600E9EBC () phabricator ! kde ! org
[Download RAW message or body]

mwolff added inline comments.

INLINE COMMENTS

> screenmapper.cpp:82
> +        // the screen got completely removed, not only its path changed
> +        pathIt = m_screensPerPath.begin();
> +        while (pathIt != m_screensPerPath.end()) {

personally I'd make this code explicit. i.e. this here is somewhat harder to grasp I \
think (and also slower, due to the repeated lookups) to something like this:

  const auto newFirstScreen = std::min_element(m_availableScreens.constBegin(), \
m_availableScreens.constEnd());  for (auto &screen : m_firstScreenForPath) {
      if (screen == screenId) {
          screen = newFirstScreen;
      }
  }

potentially we also need to update m_screensPerPath though, which the current code \
doesn't do either. The branch above does write to `pathIt` though, is this missing \
here?

> screenmapper.cpp:105
> +        for (const auto &name: it.value()) {
> +            const auto url = QUrl(name);
> +            // add the items to the new screen, if they are on a disabled screen \
> and their

unused variable, remove

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, \
                mwolff
Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (unknown)]

<table><tr><td style="">mwolff added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8493" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8493#inline-39187" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">screenmapper.cpp:82</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#74777d">// the screen got completely removed, not only its path changed</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">        <span class="n">pathIt</span> <span style="color: #aa2211">=</span> \
<span class="n">m_screensPerPath</span><span class="p">.</span><span \
class="n">begin</span><span class="p">();</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#aa4000">while</span> <span class="p">(</span><span class="n">pathIt</span> <span \
style="color: #aa2211">!=</span> <span class="n">m_screensPerPath</span><span \
class="p">.</span><span class="n">end</span><span class="p">())</span> <span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">personally I&#039;d make this code explicit. i.e. this here is somewhat harder \
to grasp I think (and also slower, due to the repeated lookups) to something like \
this:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">const auto newFirstScreen = \
std::min_element(m_availableScreens.constBegin(), m_availableScreens.constEnd()); for \
(auto &amp;screen : m_firstScreenForPath) {  if (screen == screenId) {
        screen = newFirstScreen;
    }
}</pre></div>

<p style="padding: 0; margin: 8px;">potentially we also need to update \
m_screensPerPath though, which the current code doesn&#039;t do either. The branch \
above does write to <tt style="background: #ebebeb; font-size: 13px;">pathIt</tt> \
though, is this missing here?</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8493#inline-39183" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">screenmapper.cpp:105</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> \
<span style="color: #aa4000">auto</span> <span style="color: \
#aa2211">&amp;</span><span style="color: #a0a000">name</span><span class="p">:</span> \
<span class="n">it</span><span class="p">.</span><span class="n">value</span><span \
class="p">())</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: \
#aa4000">const</span> <span style="color: #aa4000">auto</span> <span \
class="n">url</span> <span style="color: #aa2211">=</span> <span \
class="n">QUrl</span><span class="p">(</span><span class="n">name</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">            <span style="color: #74777d">// add the items \
to the new screen, if they are on a disabled screen and their</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">unused variable, remove</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8493" \
rel="noreferrer">https://phabricator.kde.org/D8493</a></div></div><br \
/><div><strong>To: </strong>amantia, Plasma, ervin, mlaurent, dvratil, hein, aacid, \
davidedmundson, apol, mwolff<br /><strong>Cc: </strong>anthonyfieroni, ngraham, \
mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]