[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8396: Add support for zwp_idle_inhibit_manager_v1
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-11-15 20:25:06
Message-ID: 20171115202504.5619.EED0D288A64FA538 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added a comment.


  In https://phabricator.kde.org/D8396#168165, @davidedmundson wrote:
  
  > I think we need some big discussion about how powerdevil inhbitions, logind \
inhibitions and this are all going to fit together in a clear coherent way.  
  
  yeah. I'm not happy with this protocol. I think it's a step backwards as we are \
again in a situation where an application can just block everything. And we don't \
have any context information available on why it's blocking.  
  The only good thing is that KWin is allowed to restrict it to when the window is \
visible (and that's something I want to implement). And we could probably pass an \
inhibition to Powerdevil informing it that "Window Foo inhibits power management".  
  > But given there are clients using this protocol already, I guess we need this \
regardless certainly at a protocol level.  
  That was the reason why I implemented it. When the protocol was added to \
wayland-protocols I didn't consider it for implementation as I thought it's useless. \
But if apps use it and don't use the dbus protocol any more...

REPOSITORY
  R127 KWayland

BRANCH
  idle-inhibit-manager

REVISION DETAIL
  https://phabricator.kde.org/D8396

To: graesslin, #frameworks, #kwin, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8396" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8396#168165" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D8396#168165</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I think we need some big discussion about \
how powerdevil inhbitions, logind inhibitions and this are all going to fit together \
in a clear coherent way.</p></div> </blockquote>

<p>yeah. I&#039;m not happy with this protocol. I think it&#039;s a step backwards as \
we are again in a situation where an application can just block everything. And we \
don&#039;t have any context information available on why it&#039;s blocking.</p>

<p>The only good thing is that KWin is allowed to restrict it to when the window is \
visible (and that&#039;s something I want to implement). And we could probably pass \
an inhibition to Powerdevil informing it that &quot;Window Foo inhibits power \
management&quot;.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>But \
given there are clients using this protocol already, I guess we need this regardless \
certainly at a protocol level.</p></blockquote>

<p>That was the reason why I implemented it. When the protocol was added to \
wayland-protocols I didn&#039;t consider it for implementation as I thought it&#039;s \
useless. But if apps use it and don&#039;t use the dbus protocol any \
more...</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 \
KWayland</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>idle-inhibit-manager</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8396" \
rel="noreferrer">https://phabricator.kde.org/D8396</a></div></div><br \
/><div><strong>To: </strong>graesslin, Frameworks, KWin, Plasma on Wayland, \
davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, leezu, \
ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
eliasp, sebas, apol, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]