[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8827: experimental support for auto mnemonics
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-11-15 18:32:19
Message-ID: 20171115183150.35347.2C94EE7B586A5374 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> mart wrote in Button.qml:43
> eww, even worse, in Qt 5.10 the mnemonics are removed in setText so is impossible \
> to know what the original text was /o\

which, they noticed it was terrible and reverted in Qt 5.11, but 5.10 is still meh, \
so the best i can do is to do something that fully correctly works only on 5.11 :/

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D8827

To: mart, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8827" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8827#inline-39097" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mart</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">Button.qml:43</span></div> <div style="margin: 8px 0; padding: 0 12px; color: \
#74777D;"><p style="padding: 0; margin: 8px;">eww, even worse, in Qt 5.10 the \
mnemonics are removed in setText so is impossible to know what the original text was \
/o\</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">which, they noticed it was terrible and reverted in Qt 5.11, but \
5.10 is still meh, so the best i can do is to do something that fully correctly works \
only on 5.11 :/</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop \
Style</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8827" \
rel="noreferrer">https://phabricator.kde.org/D8827</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>broulik, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]