[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8827: experimental support for auto mnemonics
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2017-11-15 17:38:56
Message-ID: 20171115173855.6412.6D1E83E395638C12 () phabricator ! kde ! org
[Download RAW message or body]
broulik added inline comments.
INLINE COMMENTS
> Button.qml:43
> + //in case of explicit & the button manages it by itself
> + enabled: controlRoot.text.indexOf("&") == -1
> + sequence: controlRoot.Kirigami.MnemonicData.sequence
How does it behave if text contains an `&&` ie. user explicitly wants an ampersand \
but not a mnemonic?
> kquickstyleitem.cpp:1634
> + }
> + } else {
> + if (event->type() == QEvent::KeyPress) {
Check `watched == m_window`?
> kquickstyleitem.cpp:1635
> + } else {
> + if (event->type() == QEvent::KeyPress) {
> + QKeyEvent *ke = static_cast<QKeyEvent *>(event);
You could just check `KeyPress || KeyRelease` since you're doing the same thing in \
both branches
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D8827
To: mart, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8827" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8827#inline-39093" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">Button.qml:43</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">//in case \
of explicit & the button manages it by itself</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">enabled:</span> <span style="color: #004012">controlRoot</span><span \
class="p">.</span><span style="color: #004012">text</span><span \
class="p">.</span><span style="color: #004012">indexOf</span><span \
class="p">(</span><span style="color: #766510">"&"</span><span \
class="p">)</span> <span style="color: #aa2211">==</span> <span style="color: \
#aa2211">-</span><span style="color: #601200">1</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">sequence:</span> <span style="color: #004012">controlRoot</span><span \
class="p">.</span><span style="color: #004012">Kirigami</span><span \
class="p">.</span><span style="color: #004012">MnemonicData</span><span \
class="p">.</span><span style="color: #004012">sequence</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">How \
does it behave if text contains an <tt style="background: #ebebeb; font-size: \
13px;">&&</tt> ie. user explicitly wants an ampersand but not a \
mnemonic?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8827#inline-39091" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kquickstyleitem.cpp:1634</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "> <span class="p">}</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> \
<span style="color: #aa4000">else</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">event</span><span style="color: #aa2211">-></span><span \
class="n">type</span><span class="p">()</span> <span style="color: #aa2211">==</span> \
<span class="n">QEvent</span><span style="color: #aa2211">::</span><span \
class="n">KeyPress</span><span class="p">)</span> <span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Check <tt style="background: #ebebeb; font-size: 13px;">watched == \
m_window</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D8827#inline-39092" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kquickstyleitem.cpp:1635</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> \
<span style="color: #aa4000">else</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">event</span><span style="color: #aa2211">-></span><span \
class="n">type</span><span class="p">()</span> <span style="color: #aa2211">==</span> \
<span class="n">QEvent</span><span style="color: #aa2211">::</span><span \
class="n">KeyPress</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">QKeyEvent</span> <span style="color: #aa2211">*</span><span \
class="n">ke</span> <span style="color: #aa2211">=</span> <span style="color: \
#aa4000">static_cast</span><span style="color: #aa2211"><</span><span \
class="n">QKeyEvent</span> <span style="color: #aa2211">*></span><span \
class="p">(</span><span class="n">event</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">You could just check <tt style="background: #ebebeb; font-size: \
13px;">KeyPress || KeyRelease</tt> since you're doing the same thing in both \
branches</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop \
Style</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8827" \
rel="noreferrer">https://phabricator.kde.org/D8827</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>broulik, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic