[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8798: Add xf86-input-libinput support for X11 mouse backend.
From: Nathaniel Graham <noreply () phabricator ! kde ! org>
Date: 2017-11-15 14:19:04
Message-ID: 20171115141902.96245.9C0B8CD10BF3811C () phabricator ! kde ! org
[Download RAW message or body]
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> x11mousebackend.cpp:186
> + m_supportedAccelerationProfiles.clear();
> + bool adaptiveAvaiable = false;
> + bool flatAvailable = false;
adaptiveAvaiable -> adaptiveAvailable (find-and-replace should take care of this, \
since there are many other uses of the misspelled term)
> x11mousebackend.cpp:235
> + m_accelerationProfile = PROFILE_NONE;
> + if (adaptiveAvaiable) {
> + m_accelerationProfile = PROFILE_ADAPTIVE;
Is this supposed to be "if (adaptiveEnabled) {"
> x11mousebackend.cpp:237
> + m_accelerationProfile = PROFILE_ADAPTIVE;
> + } else if (flatAvailable) {
> + m_accelerationProfile = PROFILE_FLAT;
Ditto
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham \
added inline comments.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8798" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8798#inline-39067" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">x11mousebackend.cpp:186</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">m_supportedAccelerationProfiles</span><span class="p">.</span><span \
class="n">clear</span><span class="p">();</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">bool</span> <span class="n">adaptiveAvaiable</span> <span style="color: \
#aa2211">=</span> <span style="color: #304a96">false</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">bool</span> <span \
class="n">flatAvailable</span> <span style="color: #aa2211">=</span> <span \
style="color: #304a96">false</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">adaptiveAvaiable -> adaptiveAvailable (find-and-replace should take care of \
this, since there are many other uses of the misspelled term)</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8798#inline-39068" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">x11mousebackend.cpp:235</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">m_accelerationProfile</span> <span style="color: #aa2211">=</span> <span \
class="n">PROFILE_NONE</span><span class="p">;</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">if</span> <span class="p">(</span><span \
class="n">adaptiveAvaiable</span><span class="p">)</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">m_accelerationProfile</span> <span style="color: \
#aa2211">=</span> <span class="n">PROFILE_ADAPTIVE</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Is this supposed to be "if (adaptiveEnabled) \
{"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8798#inline-39069" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">x11mousebackend.cpp:237</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">m_accelerationProfile</span> <span style="color: #aa2211">=</span> <span \
class="n">PROFILE_ADAPTIVE</span><span class="p">;</span> </div><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: \
#aa4000">if</span> <span class="p">(</span><span class="n">flatAvailable</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">m_accelerationProfile</span> <span style="color: #aa2211">=</span> <span \
class="n">PROFILE_FLAT</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Ditto</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8798" \
rel="noreferrer">https://phabricator.kde.org/D8798</a></div></div><br \
/><div><strong>To: </strong>xuetianweng, ngraham, Plasma<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic