[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8787: Fix PWD dialog
From: Christoph Feck <noreply () phabricator ! kde ! org>
Date: 2017-11-13 21:08:49
Message-ID: 20171113210848.86220.BECA4CDA44563C9E () phabricator ! kde ! org
[Download RAW message or body]
cfeck added a comment.
Please clarify. If https://phabricator.kde.org/D8791 gets accepted, which issues \
remain that would justify a custom dialog?
INLINE COMMENTS
> mountdialog.cpp:33
> + m_ui.errorLabelStatic->setVisible(false);
> + m_ui.vaultName->setText(QString(" \"%1\"").arg(vault->name()));
> +}
Is the leasing space intended?
> mountdialog.h:2
> +/*
> + * Copyright 2017 by cryptodude@libertymail.net
> + *
Add full name.
> mountdialog.h:26
> +
> +#include <ui_mountdialog.h>
> +
#include "ui_mountdialog.h"
> mountdialog.h:38
> +protected:
> + void accept();
> +
override
> mountdialog.ui:14
> + <property name="windowTitle">
> + <string>Dialog</string>
> + </property>
Adjust or remove windowTitle.
> mountdialog.ui:47
> + <item>
> + <widget class="QLineEdit" name="password">
> + <property name="echoMode">
Please use KPasswordLineEdit
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8787
To: cryptodude, #plasma, ivan
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">cfeck added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8787" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Please clarify. If <a \
href="https://phabricator.kde.org/D8791" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8791</a> gets \
accepted, which issues remain that would justify a custom dialog?</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8787#inline-38793" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mountdialog.cpp:33</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span class="n">m_ui</span><span \
class="p">.</span><span class="n">errorLabelStatic</span><span style="color: \
#aa2211">-></span><span class="n">setVisible</span><span class="p">(</span><span \
style="color: #304a96">false</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">m_ui</span><span class="p">.</span><span class="n">vaultName</span><span \
style="color: #aa2211">-></span><span class="n">setText</span><span \
class="p">(</span><span class="n">QString</span><span class="p">(</span><span \
style="color: #766510">" </span><span style="color: \
#bb6622">\"</span><span style="color: #766510">%1</span><span style="color: \
#bb6622">\"</span><span style="color: #766510">"</span><span \
class="p">).</span><span class="n">arg</span><span class="p">(</span><span \
class="n">vault</span><span style="color: #aa2211">-></span><span \
class="n">name</span><span class="p">()));</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Is the leasing space intended?</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8787#inline-38790" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mountdialog.h:2</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/*</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span style="color: #74777d"> * Copyright 2017 by \
cryptodude@libertymail.net</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> *</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Add full name.</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8787#inline-38791" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mountdialog.h:26</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#include</span> \
<span class="cpf"><ui_mountdialog.h></span><span style="color: #304a96"></span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">#include "ui_mountdialog.h"</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8787#inline-38792" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mountdialog.h:38</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span style="color: \
#a0a000">protected</span><span class="p">:</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">void</span> <span class="n">accept</span><span class="p">();</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">override</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D8787#inline-38794" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mountdialog.ui:14</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <property name="windowTitle"> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <string>Dialog</string> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> </property> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Adjust or remove windowTitle.</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8787#inline-38789" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mountdialog.ui:47</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <item> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <widget \
class="QLineEdit" name="password"> </div><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <property \
name="echoMode"> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Please use KPasswordLineEdit</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R845 Plasma Vault</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8787" \
rel="noreferrer">https://phabricator.kde.org/D8787</a></div></div><br \
/><div><strong>To: </strong>cryptodude, Plasma, ivan<br /><strong>Cc: </strong>cfeck, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic