[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8787: Fix PWD dialog
From:       Kees vd Broek <noreply () phabricator ! kde ! org>
Date:       2017-11-13 11:43:15
Message-ID: differential-rev-PHID-DREV-vjx7yrthdqdhaz4lihuc-req () phabricator ! kde ! org
[Download RAW message or body]

cryptodude created this revision.
cryptodude added reviewers: Plasma, ivan.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Replace kde4support dep with specialized pwd diag
  
  BUG:385985
  BUG:385445
  
  Drop usage of KPasswordDialog which comes from kde4support
  and make a simple dialog based on a frame.
  
  This will show the error directly in the dialog and refuse to close
  until the mount was successful.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8787

AFFECTED FILES
  kded/CMakeLists.txt
  kded/service.cpp
  kded/ui/mountdialog.cpp
  kded/ui/mountdialog.h
  kded/ui/mountdialog.ui

To: cryptodude, #plasma, ivan
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">cryptodude created this revision.<br />cryptodude added \
reviewers: Plasma, ivan.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8787" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Replace kde4support dep with specialized pwd diag</p>

<p>BUG:385985<br />
BUG:385445</p>

<p>Drop usage of KPasswordDialog which comes from kde4support<br />
and make a simple dialog based on a frame.</p>

<p>This will show the error directly in the dialog and refuse to close<br />
until the mount was successful.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R845 Plasma Vault</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8787" \
rel="noreferrer">https://phabricator.kde.org/D8787</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kded/CMakeLists.txt<br /> \
kded/service.cpp<br /> kded/ui/mountdialog.cpp<br />
kded/ui/mountdialog.h<br />
kded/ui/mountdialog.ui</div></div></div><br /><div><strong>To: </strong>cryptodude, \
Plasma, ivan<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]