[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8738: Add DBus interface to OrientationSensor and a persistent configuration
From:       Anthony Fieroni <noreply () phabricator ! kde ! org>
Date:       2017-11-09 18:36:33
Message-ID: 20171109183632.128665.34BF0B549620BC8D () phabricator ! kde ! org
[Download RAW message or body]

anthonyfieroni added inline comments.

INLINE COMMENTS

> orientation_sensor.cpp:106
> +    }
> +    m_userEnabled = m_config->group("OrientationSensor").readEntry("Enabled", \
> true); +}

m_userEnabled = m_config && m_config->group("OrientationSensor").readEntry("Enabled", \
true);

?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8738

To: graesslin, #kwin, #plasma, sebas, davidedmundson
Cc: anthonyfieroni, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8738" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8738#inline-38460" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">orientation_sensor.cpp:106</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span class="n">m_userEnabled</span> <span style="color: #aa2211">=</span> \
<span class="n">m_config</span><span style="color: #aa2211">-&gt;</span><span \
class="n">group</span><span class="p">(</span><span style="color: \
#766510">&quot;OrientationSensor&quot;</span><span class="p">).</span><span \
class="n">readEntry</span><span class="p">(</span><span style="color: \
#766510">&quot;Enabled&quot;</span><span class="p">,</span> <span style="color: \
#304a96">true</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><div \
class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">m_userEnabled = m_config \
&amp;&amp; m_config-&gt;group(&quot;OrientationSensor&quot;).readEntry(&quot;Enabled&quot;, \
true);</pre></div>

<p style="padding: 0; margin: 8px;">?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8738" \
rel="noreferrer">https://phabricator.kde.org/D8738</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, sebas, davidedmundson<br \
/><strong>Cc: </strong>anthonyfieroni, plasma-devel, kwin, bwowk, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]