[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8673: Sanitize signal handling in ksmserver
From:       Jiří Paleček <noreply () phabricator ! kde ! org>
Date:       2017-11-06 23:44:30
Message-ID: 20171106234430.29616.D41652821C657D44 () phabricator ! kde ! org
[Download RAW message or body]

jpalecek added a comment.


  In https://phabricator.kde.org/D8673#164830, @davidedmundson wrote:
  
  > Do the sockets need closing in the destructor?
  
  
  Good point. I assumed the `KSMServer` instance is practically a singleton (being \
assigned to global `the_server` etc.) which is created only once during running of \
the process. In that case, the sockets would be destroyed anyway so I kind of cut \
that corner and left it be. It would certainly be cleaner to close them in the \
destructor.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8673

To: jpalecek, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">jpalecek added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8673" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8673#164830" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D8673#164830</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Do the sockets need closing in the \
destructor?</p></div> </blockquote>

<p>Good point. I assumed the <tt style="background: #ebebeb; font-size: \
13px;">KSMServer</tt> instance is practically a singleton (being assigned to global \
<tt style="background: #ebebeb; font-size: 13px;">the_server</tt> etc.) which is \
created only once during running of the process. In that case, the sockets would be \
destroyed anyway so I kind of cut that corner and left it be. It would certainly be \
cleaner to close them in the destructor.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8673" \
rel="noreferrer">https://phabricator.kde.org/D8673</a></div></div><br \
/><div><strong>To: </strong>jpalecek, Plasma<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]