[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8598: WIP: position files at drop target position in folder
From:       Milian Wolff <noreply () phabricator ! kde ! org>
Date:       2017-11-02 14:01:50
Message-ID: 20171102140147.111131.B7F411E2E516ABFF () phabricator ! kde ! org
[Download RAW message or body]

mwolff updated this revision to Diff 21775.
mwolff added a comment.


  use copyjob signals to map the target urls, not the source urls, which
  resolves a lot of the brittleness of my previous approach. overall, this
  works quite nicely, imo and is already in an acceptable state (to me).
  
  what's left is changing the folder view sort defaults and not dropping
  to a target position when an explicit sorting/grouping was selected.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8598?vs=21717&id=21775

BRANCH
  wip/lim-2

REVISION DETAIL
  https://phabricator.kde.org/D8598

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: mwolff, hein, amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">mwolff updated this revision to Diff 21775.<br />mwolff added \
a comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8598" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>use copyjob signals to map the target \
urls, not the source urls, which<br /> resolves a lot of the brittleness of my \
previous approach. overall, this<br /> works quite nicely, imo and is already in an \
acceptable state (to me).</p>

<p>what&#039;s left is changing the folder view sort defaults and not dropping<br />
to a target position when an explicit sorting/grouping was \
selected.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D8598?vs=21717&amp;id=21775" \
rel="noreferrer">https://phabricator.kde.org/D8598?vs=21717&amp;id=21775</a></div></div><br \
/><div><strong>BRANCH</strong><div><div>wip/lim-2</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8598" \
rel="noreferrer">https://phabricator.kde.org/D8598</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>containments/desktop/plugins/folder/foldermodel.cpp<br /> \
containments/desktop/plugins/folder/foldermodel.h</div></div></div><br \
/><div><strong>To: </strong>mwolff, hein, amantia<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]