[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8567: Return the screen id for a screen name.
From:       Milian Wolff <noreply () phabricator ! kde ! org>
Date:       2017-11-01 11:02:39
Message-ID: 20171101110237.104241.A7E4D1111AB455F9 () phabricator ! kde ! org
[Download RAW message or body]

mwolff added inline comments.

INLINE COMMENTS

> shellcorona.cpp:1161
> 
> -            if (DesktopView* v = desktopForScreen(screen))
> +            if (DesktopView* v = desktopForScreen(screen)) {
> removeDesktop(v);

now you can undo this hunk

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8567

To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: mwolff, apol, mart, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (unknown)]

<table><tr><td style="">mwolff added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8567" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8567#inline-37466" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">shellcorona.cpp:1161</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: \
#aa4000">if</span> <span class="p">(</span><span class="n">DesktopView</span><span \
style="color: #aa2211">*</span> <span class="n">v</span> <span style="color: \
#aa2211">=</span> <span class="n">desktopForScreen</span><span \
class="p">(</span><span class="n">screen</span><span class="p">))</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">DesktopView</span><span style="color: #aa2211">*</span> <span \
class="n">v</span> <span style="color: #aa2211">=</span> <span \
class="n">desktopForScreen</span><span class="p">(</span><span \
class="n">screen</span><span class="p">))<span class="bright"></span></span><span \
class="bright"> </span><span class="p"><span class="bright">{</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span \
class="n">removeDesktop</span><span class="p">(</span><span class="n">v</span><span \
class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">now \
you can undo this hunk</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8567" \
rel="noreferrer">https://phabricator.kde.org/D8567</a></div></div><br \
/><div><strong>To: </strong>amantia, Plasma, ervin, dvratil, mlaurent, hein<br \
/><strong>Cc: </strong>mwolff, apol, mart, davidedmundson, plasma-devel, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]