[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8582: [platforms/drm] Add support for rotation property on the Plane
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2017-10-31 17:55:48
Message-ID: 20171031175509.26866.4C8AF57731043C05 () phabricator ! kde ! org
[Download RAW message or body]

subdiff added inline comments.

INLINE COMMENTS

> drm_object_plane.cpp:125
> +{
> +    if (m_rotation == r) {
> +        return;

Check not necessary.

> drm_object_plane.h:107
> uint32_t m_possibleCrtcs;
> +    Rotation m_rotation = Rotation::Rotate0;
> };

I wouldn't add an additional variable, since its value is saved in the Rotation \
property. You can retrieve it by calling

  DrmObject::value((int)PropertyIndex::Rotation)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8582

To: graesslin, #kwin, #plasma, subdiff
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">subdiff added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8582" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8582#inline-37381" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">drm_object_plane.cpp:125</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">m_rotation</span> <span style="color: #aa2211">==</span> <span \
class="n">r</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span style="color: #aa4000">return</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Check not necessary.</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8582#inline-37372" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">drm_object_plane.h:107</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">    <span style="color: #aa4000">uint32_t</span> <span \
class="n">m_possibleCrtcs</span><span class="p">;</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">Rotation</span> <span class="n">m_rotation</span> <span style="color: \
#aa2211">=</span> <span class="n">Rotation</span><span style="color: \
#aa2211">::</span><span class="n">Rotate0</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; "><span class="p">};</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
wouldn&#039;t add an additional variable, since its value is saved in the Rotation \
property. You can retrieve it by calling</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, \
0.08);">DrmObject::value((int)PropertyIndex::Rotation)</pre></div></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8582" \
rel="noreferrer">https://phabricator.kde.org/D8582</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, subdiff<br /><strong>Cc: \
</strong>plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]