[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8444: Define default Action when we plug unknown monitor
From:       Sebastian_Kügler <noreply () phabricator ! kde ! org>
Date:       2017-10-31 9:00:58
Message-ID: 20171031090057.113429.94AAC6780CB5E005 () phabricator ! kde ! org
[Download RAW message or body]

sebas added a comment.


  Once you're done with the code, please also add screenshot so usability can have a \
look at it. I'm not sure we should add UI for this, the screen setup is already very \
complex and hard to understand. Perhaps a set of clear use-cases would make this \
clearer?  
  No unit tests for the code (I know, hard to do) will add to the maintenance burden, \
which is already high.  
  Just seeing the code is definitely not enough for me to ACK this.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent, davidedmundson
Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">sebas added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8444" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Once you&#039;re done with the code, \
please also add screenshot so usability can have a look at it. I&#039;m not sure we \
should add UI for this, the screen setup is already very complex and hard to \
understand. Perhaps a set of clear use-cases would make this clearer?</p>

<p>No unit tests for the code (I know, hard to do) will add to the maintenance \
burden, which is already high.</p>

<p>Just seeing the code is definitely not enough for me to ACK \
this.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R104 \
KScreen</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8444" \
rel="noreferrer">https://phabricator.kde.org/D8444</a></div></div><br \
/><div><strong>To: </strong>mlaurent, davidedmundson<br /><strong>Cc: </strong>sebas, \
graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]